[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v2 1/7] vhost: Delete trailing dot in errpr_setg argument
From: |
Eugenio Perez Martin |
Subject: |
Re: [RFC v2 1/7] vhost: Delete trailing dot in errpr_setg argument |
Date: |
Tue, 9 Feb 2021 19:11:41 +0100 |
On Tue, Feb 9, 2021 at 5:25 PM Eric Blake <eblake@redhat.com> wrote:
>
> On 2/9/21 9:37 AM, Eugenio Pérez wrote:
> > As error_setg points
>
> Incomplete sentence?
>
> Missing Signed-off-by.
>
Sorry, I should have paid more attention.
Maybe it is better to send this though qemu-trivial, so it does not
mess with this series?
Thanks!
> > ---
> > hw/virtio/vhost.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> > index 6e17d631f7..1c5b442081 100644
> > --- a/hw/virtio/vhost.c
> > +++ b/hw/virtio/vhost.c
> > @@ -1358,7 +1358,7 @@ int vhost_dev_init(struct vhost_dev *hdev, void
> > *opaque,
> > if (hdev->migration_blocker == NULL) {
> > if (!(hdev->features & (0x1ULL << VHOST_F_LOG_ALL))) {
> > error_setg(&hdev->migration_blocker,
> > - "Migration disabled: vhost lacks VHOST_F_LOG_ALL
> > feature.");
> > + "Migration disabled: vhost lacks VHOST_F_LOG_ALL
> > feature");
> > } else if (vhost_dev_log_is_shared(hdev) &&
> > !qemu_memfd_alloc_check()) {
> > error_setg(&hdev->migration_blocker,
> > "Migration disabled: failed to allocate shared
> > memory");
> >
>
> --
> Eric Blake, Principal Software Engineer
> Red Hat, Inc. +1-919-301-3226
> Virtualization: qemu.org | libvirt.org
>
- [RFC v2 0/7] vDPA shadow virtqueue - notifications forwarding, Eugenio Pérez, 2021/02/09
- [RFC v2 2/7] virtio: Add virtio_queue_host_notifier_status, Eugenio Pérez, 2021/02/09
- [RFC v2 3/7] vhost: Save masked_notifier state, Eugenio Pérez, 2021/02/09
- [RFC v2 4/7] vhost: Add VhostShadowVirtqueue, Eugenio Pérez, 2021/02/09
- [RFC v2 5/7] vhost: Add x-vhost-enable-shadow-vq qmp, Eugenio Pérez, 2021/02/09