[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v1 05/12] tests/plugin: expand insn test to detect duplicate inst
From: |
Alex Bennée |
Subject: |
[PATCH v1 05/12] tests/plugin: expand insn test to detect duplicate instructions |
Date: |
Tue, 9 Feb 2021 18:27:41 +0000 |
A duplicate insn is one that is appears to be executed twice in a row.
This is currently possible due to -icount and cpu_io_recompile()
causing a re-translation of a block. On it's own this won't trigger
any tests though.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
[AJB: well not quite, the x86_64 test trips over this due to some
weirdness in the way we handle rep insns, e.g. rep movsb (%esi),
%es:(%edi) in the x86 bios code]
---
tests/plugin/insn.c | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/plugin/insn.c b/tests/plugin/insn.c
index a9a6e41237..c253980ec8 100644
--- a/tests/plugin/insn.c
+++ b/tests/plugin/insn.c
@@ -21,6 +21,14 @@ static bool do_inline;
static void vcpu_insn_exec_before(unsigned int cpu_index, void *udata)
{
+ static uint64_t last_pc;
+ uint64_t this_pc = GPOINTER_TO_UINT(udata);
+ if (this_pc == last_pc) {
+ g_autofree gchar *out = g_strdup_printf("detected repeat execution @
0x%"
+ PRIx64 "\n", this_pc);
+ qemu_plugin_outs(out);
+ }
+ last_pc = this_pc;
insn_count++;
}
@@ -36,8 +44,10 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct
qemu_plugin_tb *tb)
qemu_plugin_register_vcpu_insn_exec_inline(
insn, QEMU_PLUGIN_INLINE_ADD_U64, &insn_count, 1);
} else {
+ uint64_t vaddr = qemu_plugin_insn_vaddr(insn);
qemu_plugin_register_vcpu_insn_exec_cb(
- insn, vcpu_insn_exec_before, QEMU_PLUGIN_CB_NO_REGS, NULL);
+ insn, vcpu_insn_exec_before, QEMU_PLUGIN_CB_NO_REGS,
+ GUINT_TO_POINTER(vaddr));
}
}
}
--
2.20.1
- [PATCH v1 00/12] fix plugins double counting with mmio, cleanup CF_ flags, Alex Bennée, 2021/02/09
- [PATCH v1 01/12] exec: Move TranslationBlock typedef to qemu/typedefs.h, Alex Bennée, 2021/02/09
- [PATCH v1 04/12] target/sh4: Create superh_io_recompile_replay_branch, Alex Bennée, 2021/02/09
- [PATCH v1 03/12] target/mips: Create mips_io_recompile_replay_branch, Alex Bennée, 2021/02/09
- [PATCH v1 02/12] accel/tcg: Create io_recompile_replay_branch hook, Alex Bennée, 2021/02/09
- [PATCH v1 05/12] tests/plugin: expand insn test to detect duplicate instructions,
Alex Bennée <=
- [PATCH v1 09/12] accel/tcg: re-factor non-RAM execution code, Alex Bennée, 2021/02/09
- [PATCH v1 12/12] tests/acceptance: add a new tests to detect counting errors, Alex Bennée, 2021/02/09
- [PATCH v1 11/12] accel/tcg: allow plugin instrumentation to be disable via cflags, Alex Bennée, 2021/02/09
- [PATCH v1 07/12] accel/tcg: actually cache our partial icount TB, Alex Bennée, 2021/02/09
- [PATCH v1 08/12] accel/tcg: cache single instruction TB on pending replay exception, Alex Bennée, 2021/02/09