Re: [PATCH v2 6/9] hw/i386: declare ACPI mother board resource for MMCONFIG region

[Michael S. Tsirkin]

On Tue, Feb 09, 2021 at 04:52:41PM +0100, Igor Mammedov wrote:
> > ---
> >  hw/i386/acpi-build.c | 172 +++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 172 insertions(+)
> > 
> > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
> > index c2f11d95d8..bcb1f65c1d 100644
> > --- a/hw/i386/acpi-build.c
> > +++ b/hw/i386/acpi-build.c
> > @@ -1066,6 +1066,177 @@ static void build_q35_pci0_int(Aml *table)
> >      aml_append(table, sb_scope);
> >  }
> >  
> > +static Aml *build_q35_dram_controller(void)
> > +{
> > +    /*
> > +     * DSDT is created with revision 1 which means 32bit integer.
> version 1, is kept for Windows XP sake which is EOLed long ago,
> and it even will boot with v2 as long as AML doesn't contain non v1
> terms or those are hidden behind dynamic method which are not evaluated.

right, this are doing lots of dynamic stuff, generally it is easy to hide
things there.  E.g. 

if (high != 0) return qword else return dword

> Perhaps we should bump dsdt revision to v2.

I agree that bumping up to v2 is likely safe ...

> And anyways with this patch XP probably will trip over, if it tries to parse
> 64bit CRS, but we probably don't care about XP on q35.

Yea I'm not sure why are we using qword here.

-- 
MST