[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v4 16/27] multi-process: Initialize message handler in remote devi
From: |
Stefan Hajnoczi |
Subject: |
[PULL v4 16/27] multi-process: Initialize message handler in remote device |
Date: |
Wed, 10 Feb 2021 09:26:17 +0000 |
From: Jagannathan Raman <jag.raman@oracle.com>
Initializes the message handler function in the remote process. It is
called whenever there's an event pending on QIOChannel that registers
this function.
Signed-off-by: Elena Ufimtseva <elena.ufimtseva@oracle.com>
Signed-off-by: John G Johnson <john.g.johnson@oracle.com>
Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id:
99d38d8b93753a6409ac2340e858858cda59ab1b.1611938319.git.jag.raman@oracle.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
MAINTAINERS | 1 +
include/hw/remote/machine.h | 9 ++++++
hw/remote/message.c | 57 +++++++++++++++++++++++++++++++++++++
hw/remote/meson.build | 1 +
4 files changed, 68 insertions(+)
create mode 100644 hw/remote/message.c
diff --git a/MAINTAINERS b/MAINTAINERS
index 389693f59a..8d2693525c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3213,6 +3213,7 @@ F: hw/remote/machine.c
F: include/hw/remote/machine.h
F: hw/remote/mpqemu-link.c
F: include/hw/remote/mpqemu-link.h
+F: hw/remote/message.c
Build and test automation
-------------------------
diff --git a/include/hw/remote/machine.h b/include/hw/remote/machine.h
index bdfbca40b9..b92b2ce705 100644
--- a/include/hw/remote/machine.h
+++ b/include/hw/remote/machine.h
@@ -14,6 +14,7 @@
#include "qom/object.h"
#include "hw/boards.h"
#include "hw/pci-host/remote.h"
+#include "io/channel.h"
struct RemoteMachineState {
MachineState parent_obj;
@@ -21,7 +22,15 @@ struct RemoteMachineState {
RemotePCIHost *host;
};
+/* Used to pass to co-routine device and ioc. */
+typedef struct RemoteCommDev {
+ PCIDevice *dev;
+ QIOChannel *ioc;
+} RemoteCommDev;
+
#define TYPE_REMOTE_MACHINE "x-remote-machine"
OBJECT_DECLARE_SIMPLE_TYPE(RemoteMachineState, REMOTE_MACHINE)
+void coroutine_fn mpqemu_remote_msg_loop_co(void *data);
+
#endif
diff --git a/hw/remote/message.c b/hw/remote/message.c
new file mode 100644
index 0000000000..36e2d4fb0c
--- /dev/null
+++ b/hw/remote/message.c
@@ -0,0 +1,57 @@
+/*
+ * Copyright © 2020, 2021 Oracle and/or its affiliates.
+ *
+ * This work is licensed under the terms of the GNU GPL-v2, version 2 or later.
+ *
+ * See the COPYING file in the top-level directory.
+ *
+ */
+
+#include "qemu/osdep.h"
+#include "qemu-common.h"
+
+#include "hw/remote/machine.h"
+#include "io/channel.h"
+#include "hw/remote/mpqemu-link.h"
+#include "qapi/error.h"
+#include "sysemu/runstate.h"
+
+void coroutine_fn mpqemu_remote_msg_loop_co(void *data)
+{
+ g_autofree RemoteCommDev *com = (RemoteCommDev *)data;
+ PCIDevice *pci_dev = NULL;
+ Error *local_err = NULL;
+
+ assert(com->ioc);
+
+ pci_dev = com->dev;
+ for (; !local_err;) {
+ MPQemuMsg msg = {0};
+
+ if (!mpqemu_msg_recv(&msg, com->ioc, &local_err)) {
+ break;
+ }
+
+ if (!mpqemu_msg_valid(&msg)) {
+ error_setg(&local_err, "Received invalid message from proxy"
+ "in remote process pid="FMT_pid"",
+ getpid());
+ break;
+ }
+
+ switch (msg.cmd) {
+ default:
+ error_setg(&local_err,
+ "Unknown command (%d) received for device %s"
+ " (pid="FMT_pid")",
+ msg.cmd, DEVICE(pci_dev)->id, getpid());
+ }
+ }
+
+ if (local_err) {
+ error_report_err(local_err);
+ qemu_system_shutdown_request(SHUTDOWN_CAUSE_HOST_ERROR);
+ } else {
+ qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
+ }
+}
diff --git a/hw/remote/meson.build b/hw/remote/meson.build
index a2b2fc0e59..9f5c57f35a 100644
--- a/hw/remote/meson.build
+++ b/hw/remote/meson.build
@@ -2,5 +2,6 @@ remote_ss = ss.source_set()
remote_ss.add(when: 'CONFIG_MULTIPROCESS', if_true: files('machine.c'))
remote_ss.add(when: 'CONFIG_MULTIPROCESS', if_true: files('mpqemu-link.c'))
+remote_ss.add(when: 'CONFIG_MULTIPROCESS', if_true: files('message.c'))
softmmu_ss.add_all(when: 'CONFIG_MULTIPROCESS', if_true: remote_ss)
--
2.29.2
- [PULL v4 06/27] get_maintainer: update repo URL to GitLab, (continued)
- [PULL v4 06/27] get_maintainer: update repo URL to GitLab, Stefan Hajnoczi, 2021/02/10
- [PULL v4 07/27] multi-process: add the concept description to docs/devel/qemu-multiprocess, Stefan Hajnoczi, 2021/02/10
- [PULL v4 08/27] multi-process: add configure and usage information, Stefan Hajnoczi, 2021/02/10
- [PULL v4 09/27] memory: alloc RAM from file at offset, Stefan Hajnoczi, 2021/02/10
- [PULL v4 10/27] multi-process: Add config option for multi-process QEMU, Stefan Hajnoczi, 2021/02/10
- [PULL v4 11/27] multi-process: setup PCI host bridge for remote device, Stefan Hajnoczi, 2021/02/10
- [PULL v4 12/27] multi-process: setup a machine object for remote device process, Stefan Hajnoczi, 2021/02/10
- [PULL v4 13/27] io: add qio_channel_writev_full_all helper, Stefan Hajnoczi, 2021/02/10
- [PULL v4 14/27] io: add qio_channel_readv_full_all_eof & qio_channel_readv_full_all helpers, Stefan Hajnoczi, 2021/02/10
- [PULL v4 15/27] multi-process: define MPQemuMsg format and transmission functions, Stefan Hajnoczi, 2021/02/10
- [PULL v4 16/27] multi-process: Initialize message handler in remote device,
Stefan Hajnoczi <=
- [PULL v4 18/27] multi-process: setup memory manager for remote device, Stefan Hajnoczi, 2021/02/10
- [PULL v4 17/27] multi-process: Associate fd of a PCIDevice with its object, Stefan Hajnoczi, 2021/02/10
- [PULL v4 19/27] multi-process: introduce proxy object, Stefan Hajnoczi, 2021/02/10
- [PULL v4 20/27] multi-process: add proxy communication functions, Stefan Hajnoczi, 2021/02/10
- [PULL v4 21/27] multi-process: Forward PCI config space acceses to the remote process, Stefan Hajnoczi, 2021/02/10
- [PULL v4 22/27] multi-process: PCI BAR read/write handling for proxy & remote endpoints, Stefan Hajnoczi, 2021/02/10
- [PULL v4 23/27] multi-process: Synchronize remote memory, Stefan Hajnoczi, 2021/02/10
- [PULL v4 24/27] multi-process: create IOHUB object to handle irq, Stefan Hajnoczi, 2021/02/10
- [PULL v4 25/27] multi-process: Retrieve PCI info from remote process, Stefan Hajnoczi, 2021/02/10
- [PULL v4 26/27] multi-process: perform device reset in the remote process, Stefan Hajnoczi, 2021/02/10