[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq()
From: |
Bin Meng |
Subject: |
Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq() |
Date: |
Wed, 10 Feb 2021 18:15:55 +0800 |
On Wed, Feb 10, 2021 at 5:54 PM Bin Meng <bmeng.cn@gmail.com> wrote:
>
> From: Bin Meng <bin.meng@windriver.com>
>
> Current QEMU HEAD nvme.c does not compile:
>
> hw/block/nvme.c: In function ‘nvme_process_sq’:
Not sure why compiler reports this error happens in nvme_process_sq()?
But it should be in nvme_get_feature(). I will update the commit message in v2.
> hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
> trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
> ^
> hw/block/nvme.c:3150:14: note: ‘result’ was declared here
> uint32_t result;
> ^
>
> Explicitly initialize the result to fix it.
>
> Fixes: aa5e55e3b07e ("hw/block/nvme: open code for volatile write cache")
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
> ---
>
> hw/block/nvme.c | 1 +
> 1 file changed, 1 insertion(+)
>
Regards,
Bin
- [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq(), Bin Meng, 2021/02/10
- Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq(),
Bin Meng <=
- Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq(), Klaus Jensen, 2021/02/10
- Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq(), Bin Meng, 2021/02/10
- Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq(), Klaus Jensen, 2021/02/10
- Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq(), Peter Maydell, 2021/02/10
- Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq(), Klaus Jensen, 2021/02/10
- Re: [PATCH] hw/block: nvme: Fix a build error in nvme_process_sq(), Peter Maydell, 2021/02/10