[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature()
From: |
Minwoo Im |
Subject: |
Re: [PATCH v2] hw/block: nvme: Fix a build error in nvme_get_feature() |
Date: |
Wed, 10 Feb 2021 19:47:57 +0900 |
User-agent: |
Mutt/1.11.4 (2019-03-13) |
On 21-02-10 18:23:17, Bin Meng wrote:
> From: Bin Meng <bin.meng@windriver.com>
>
> Current QEMU HEAD nvme.c does not compile:
>
> hw/block/nvme.c:3242:9: error: ‘result’ may be used uninitialized in this
> function [-Werror=maybe-uninitialized]
> trace_pci_nvme_getfeat_vwcache(result ? "enabled" : "disabled");
> ^
> hw/block/nvme.c:3150:14: note: ‘result’ was declared here
> uint32_t result;
> ^
>
> Explicitly initialize the result to fix it.
>
> Fixes: aa5e55e3b07e ("hw/block/nvme: open code for volatile write cache")
> Signed-off-by: Bin Meng <bin.meng@windriver.com>
Bin,
Thanks for the fix!