[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH v2 0/4] Allow changing bs->file on reopen
From: |
Kevin Wolf |
Subject: |
Re: [RFC PATCH v2 0/4] Allow changing bs->file on reopen |
Date: |
Wed, 10 Feb 2021 18:26:57 +0100 |
Am 08.02.2021 um 19:44 hat Alberto Garcia geschrieben:
> Hi,
>
> this series allows changing bs->file using x-blockdev-reopen. Read
> here for more details:
>
> https://lists.gnu.org/archive/html/qemu-block/2021-01/msg00437.html
>
> Version 2 of the series introduces a very significant change:
> x-blockdev-reopen now receives a list of BlockdevOptions instead of
> just one, so it is possible to reopen multiple block devices using a
> single transaction.
Adding Peter to Cc for this one.
> This is still an RFC, I haven't updated the documentation and the
> structure of the patches will probably change in the future, but I'd
> like to know your opinion about the approach.
I like the direction where this is going.
You have a test case for adding a throttling filter. Can we also remove
it again or is there still a problem with that? I seem to remember that
that was a bit trickier, though I'm not sure what it was. Was it that we
can't have the throttle node without a file, so it would possibly still
have permission conflicts?
Kevin
- Re: [RFC PATCH v2 1/4] block: Allow changing bs->file on reopen, (continued)