[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] meson: adjust timeouts for some slower tests

From: Paolo Bonzini
Subject: Re: [PATCH] meson: adjust timeouts for some slower tests
Date: Thu, 11 Feb 2021 12:30:35 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 09/02/21 18:58, Daniel P. Berrangé wrote:
On Tue, Feb 09, 2021 at 06:45:41PM +0100, Paolo Bonzini wrote:
Adjust the timeouts for the longest running tests.  These are the
times that I measured and the corresponding timeouts.  For generic
qtests, the target that reported the longest runtime is included.

unit tests:
     test-crypto-tlscredsx509        13.15s   60s
     test-crypto-tlssession          14.12s   60s

The default meson timeout is 30 seconds which is enough for these
tests. Of course larger timeouts give more headroom.

This was a relatively fast run, I've had them take as little as 7s and as much as 25s on the same machine. I suspect it's because the machine has a very slow NFS home directory (yes those things still exist :)). In general a 2x-ish headroom makes sense in case someone is doing a build at the same time as a test run.

By the way, with Meson 0.57 there's the possibility of specifying "infinite timeout", and this could be used for the benchmarks. Giving slower tests a higher priority is also a good idea, and even though this is not guaranteed in theory, Make ends up taking into account the priority as well. With these tweaks "meson test" and "make check" (minus check-block of course) both clock at 2:20s, which is exactly the time it takes to run the longest-running test.

I will also give "meson test" a shot on the GitLab runners before posting v2, and see if it needs a timeout multiplier.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]