[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH] target/mips/cp0_timer: Use new clock_ns_to_ticks()
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [RFC PATCH] target/mips/cp0_timer: Use new clock_ns_to_ticks() |
Date: |
Thu, 11 Feb 2021 12:34:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 2/11/21 12:25 PM, no-reply@patchew.org wrote:
> Patchew URL:
> 20210210234334.3750022-1-f4bug@amsat.org/">https://patchew.org/QEMU/20210210234334.3750022-1-f4bug@amsat.org/
>
>
>
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Type: series
> Message-id: 20210210234334.3750022-1-f4bug@amsat.org
> Subject: [RFC PATCH] target/mips/cp0_timer: Use new clock_ns_to_ticks()
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Switched to a new branch 'test'
> 86c0e95 target/mips/cp0_timer: Use new clock_ns_to_ticks()
>
> === OUTPUT BEGIN ===
> ERROR: space prohibited after that '-' (ctx:ExW)
> #39: FILE: target/mips/cp0_timer.c:41:
> + - (uint32_t)(now_ticks / cpu->cp0_count_rate);
> ^
Well, having the operator at the beginning of the line makes
it more obvious than having it at the end of the previous line.
I can remove the space to make checkpatch happy but it seems
wrong.