[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 09/24] python: add pylint import exceptions
From: |
John Snow |
Subject: |
[PATCH v4 09/24] python: add pylint import exceptions |
Date: |
Thu, 11 Feb 2021 13:58:41 -0500 |
Pylint 2.5.x and 2.6.x have regressions that make import checking
inconsistent, see:
https://github.com/PyCQA/pylint/issues/3609
https://github.com/PyCQA/pylint/issues/3624
https://github.com/PyCQA/pylint/issues/3651
Pinning to 2.4.4 is worse, because it mandates versions of shared
dependencies that are too old for features we want in isort and mypy.
Oh well.
Signed-off-by: John Snow <jsnow@redhat.com>
---
python/qemu/machine/__init__.py | 3 +++
python/qemu/machine/machine.py | 2 +-
python/qemu/machine/qtest.py | 2 +-
3 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/qemu/machine/__init__.py b/python/qemu/machine/__init__.py
index 891a8f784b5..6881f424c63 100644
--- a/python/qemu/machine/__init__.py
+++ b/python/qemu/machine/__init__.py
@@ -22,6 +22,9 @@
# the COPYING file in the top-level directory.
#
+# pylint: disable=import-error
+# see: https://github.com/PyCQA/pylint/issues/3624
+# see: https://github.com/PyCQA/pylint/issues/3651
from .machine import QEMUMachine
from .qtest import QEMUQtestMachine, QEMUQtestProtocol
diff --git a/python/qemu/machine/machine.py b/python/qemu/machine/machine.py
index dd6ce289350..4c1fde6101a 100644
--- a/python/qemu/machine/machine.py
+++ b/python/qemu/machine/machine.py
@@ -38,7 +38,7 @@
Type,
)
-from qemu.qmp import (
+from qemu.qmp import ( # pylint: disable=import-error
QEMUMonitorProtocol,
QMPMessage,
QMPReturnValue,
diff --git a/python/qemu/machine/qtest.py b/python/qemu/machine/qtest.py
index 53926e434a7..c3adf4e3012 100644
--- a/python/qemu/machine/qtest.py
+++ b/python/qemu/machine/qtest.py
@@ -26,7 +26,7 @@
TextIO,
)
-from qemu.qmp import SocketAddrT
+from qemu.qmp import SocketAddrT # pylint: disable=import-error
from .machine import QEMUMachine
--
2.29.2
- [PATCH v4 08/24] python: Add pipenv support, (continued)
[PATCH v4 06/24] python: add VERSION file, John Snow, 2021/02/11
[PATCH v4 17/24] python/qemu: add isort to pipenv, John Snow, 2021/02/11
[PATCH v4 09/24] python: add pylint import exceptions,
John Snow <=
[PATCH v4 14/24] python: move mypy.ini into setup.cfg, John Snow, 2021/02/11
[PATCH v4 10/24] python: move pylintrc into setup.cfg, John Snow, 2021/02/11
[PATCH v4 11/24] python: add pylint to pipenv, John Snow, 2021/02/11
[PATCH v4 07/24] python: add directory structure README.rst files, John Snow, 2021/02/11