Re: [RFC PATCH 03/10] target/hexagon: make helper functions non-static

[Philippe Mathieu-Daudé]

On 2/12/21 12:04 AM, Philippe Mathieu-Daudé wrote:
> On 2/11/21 10:50 PM, Alessandro Di Federico via wrote:
>> From: Paolo Montesel <babush@rev.ng>
>>
>> Move certain helper functions required by code generated by the
>> idef-parser available outside genptr.c, moving them into macros.h.
>>
> 
> ^ OK
> 
>> This patch also introduces the gen_cancel and gen_fbrev helper which
>> will be used by idef-parser.
> 
> No, it doesn't. Probably old comment?
> 
> Removing it:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 

Missing Paolo's s-o-b?

>>
>> Signed-off-by: Alessandro Di Federico <ale@rev.ng>
>> ---
>>  target/hexagon/genptr.c | 13 ++++++++++---
>>  target/hexagon/genptr.h |  7 +++++++
>>  2 files changed, 17 insertions(+), 3 deletions(-)