[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 17/35] Hexagon (target/hexagon/fma_emu.[ch]) utility funct
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v8 17/35] Hexagon (target/hexagon/fma_emu.[ch]) utility functions |
Date: |
Fri, 12 Feb 2021 01:31:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 2/8/21 6:46 AM, Taylor Simpson wrote:
> Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
> ---
> target/hexagon/fma_emu.h | 36 +++
> target/hexagon/fma_emu.c | 702
> +++++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 738 insertions(+)
> create mode 100644 target/hexagon/fma_emu.h
> create mode 100644 target/hexagon/fma_emu.c
I'm not a floating point specialist (Alex, Laurent, feel free to
review on top), however this patch LGTM:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- Re: [PATCH v8 09/35] Hexagon (target/hexagon) architecture types, (continued)
- [PATCH v8 26/35] Hexagon (target/hexagon) TCG generation, Taylor Simpson, 2021/02/08
- [PATCH v8 10/35] Hexagon (target/hexagon) instruction and packet types, Taylor Simpson, 2021/02/08
- [PATCH v8 15/35] Hexagon (target/hexagon/arch.[ch]) utility functions, Taylor Simpson, 2021/02/08
- [PATCH v8 25/35] Hexagon (target/hexagon) instruction classes, Taylor Simpson, 2021/02/08
- [PATCH v8 17/35] Hexagon (target/hexagon/fma_emu.[ch]) utility functions, Taylor Simpson, 2021/02/08
- [PATCH v8 20/35] Hexagon (target/hexagon) generator phase 2 - generate header files, Taylor Simpson, 2021/02/08
- [PATCH v8 23/35] Hexagon (target/hexagon) opcode data structures, Taylor Simpson, 2021/02/08
- [PATCH v8 07/35] Hexagon (target/hexagon) scalar core helpers, Taylor Simpson, 2021/02/08
- [PATCH v8 16/35] Hexagon (target/hexagon/conv_emu.[ch]) utility functions, Taylor Simpson, 2021/02/08
- [PATCH v8 24/35] Hexagon (target/hexagon) macros, Taylor Simpson, 2021/02/08