Re: [PATCH] io: error_prepend() in qio_channel_readv_full_all() causes segfault

[Jag Raman]

> On Feb 12, 2021, at 8:08 AM, Eric Blake <eblake@redhat.com> wrote:
> 
> On 2/12/21 5:41 AM, Jag Raman wrote:
>> 
>> 
>>> On Feb 12, 2021, at 6:16 AM, Daniel P. Berrangé <berrange@redhat.com> wrote:
>>> 
>>> On Fri, Feb 12, 2021 at 06:16:07AM -0500, Jagannathan Raman wrote:
>>>> Using error_prepend() in qio_channel_readv_full_all() causes a segfault
>>>> as errp is not set when ret is 0. This results in the failure of iotest
>>>> 83. Replacing with error_setg() fixes the problem.
>>>> 
>>>> Additionally, removes a full stop at the end of error message
>>>> 
>>>> Reported-by: Max Reitz <mreitz@redhat.com>
>>>> Signed-off-by: Jagannathan Raman <jag.raman@oracle.com>
>>>> ---
>>>> io/channel.c | 3 +--
>>>> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
>>> 
>>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>> 
>> Thank you for reviewing, Daniel! I recall that you warned about
>> error_prepend() during the review, somehow slipped through.
>> 
>> Hi Peter,
>> 
>>    Could we send a PULL request for this patch?
> 
> I'm bundling up a pull request for my NBD tree, and will include this one.

Thank you very much, Eric! :)

> 
> -- 
> Eric Blake, Principal Software Engineer
> Red Hat, Inc.           +1-919-301-3226
> Virtualization:  qemu.org | libvirt.org