[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/24] hw/misc/mps2-fpgaio: Make number of LEDs configurable
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH 05/24] hw/misc/mps2-fpgaio: Make number of LEDs configurable by board |
Date: |
Fri, 12 Feb 2021 19:19:23 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/5/21 6:00 PM, Peter Maydell wrote:
> The MPS2 board has 2 LEDs, but the MPS3 board has 10 LEDs. The
> FPGAIO device is similar on both sets of boards, but the LED0
> register has correspondingly more bits that have an effect. Add a
> device property for number of LEDs.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> include/hw/misc/mps2-fpgaio.h | 5 ++++-
> hw/misc/mps2-fpgaio.c | 31 +++++++++++++++++++++++--------
> 2 files changed, 27 insertions(+), 9 deletions(-)
All LEDs are green so we are good for now.
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 00/24] hw/arm: New board model mps3-an524, Peter Maydell, 2021/02/05
- [PATCH 01/24] hw/arm/mps2-tz: Make SYSCLK frequency board-specific, Peter Maydell, 2021/02/05
- [PATCH 02/24] hw/misc/mps2-scc: Support configurable number of OSCCLK values, Peter Maydell, 2021/02/05
- [PATCH 03/24] hw/arm/mps2-tz: Correct the OSCCLK settings for mps2-an505 and mps2-an511, Peter Maydell, 2021/02/05
- [PATCH 04/24] hw/arm/mps2-tz: Make the OSCCLK settings be configurable per-board, Peter Maydell, 2021/02/05
- [PATCH 05/24] hw/misc/mps2-fpgaio: Make number of LEDs configurable by board, Peter Maydell, 2021/02/05
- Re: [PATCH 05/24] hw/misc/mps2-fpgaio: Make number of LEDs configurable by board,
Philippe Mathieu-Daudé <=
- [PATCH 07/24] hw/arm/mps2-tz: Make FPGAIO switch and LED config per-board, Peter Maydell, 2021/02/05
- [PATCH 06/24] hw/misc/mps2-fpgaio: Support SWITCH register, Peter Maydell, 2021/02/05
- Re: [PATCH 06/24] hw/misc/mps2-fpgaio: Support SWITCH register, Philippe Mathieu-Daudé, 2021/02/12
- [PATCH 10/24] hw/misc/mps2-scc: Implement CFG_REG5 and CFG_REG6 for MPS3 AN524, Peter Maydell, 2021/02/05
- [PATCH 09/24] hw/arm/mps2-tz: Make number of IRQs board-specific, Peter Maydell, 2021/02/05