[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 05/31] exec: Improve types for guest_addr_valid
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v7 05/31] exec: Improve types for guest_addr_valid |
|
Date: |
Fri, 12 Feb 2021 20:07:41 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/12/21 7:48 PM, Richard Henderson wrote:
> Return bool not int; pass abi_ulong not 'unsigned long'.
> All callers use abi_ulong already, so the change in type
> has no effect.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> include/exec/cpu_ldst.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH v7 00/31] target-arm: Implement ARMv8.5-MemTag, user mode, Richard Henderson, 2021/02/12
- [PATCH v7 01/31] tcg: Introduce target-specific page data for user-only, Richard Henderson, 2021/02/12
- [PATCH v7 02/31] linux-user: Introduce PAGE_ANON, Richard Henderson, 2021/02/12
- [PATCH v7 03/31] exec: Use uintptr_t for guest_base, Richard Henderson, 2021/02/12
- [PATCH v7 05/31] exec: Improve types for guest_addr_valid, Richard Henderson, 2021/02/12
- Re: [PATCH v7 05/31] exec: Improve types for guest_addr_valid,
Philippe Mathieu-Daudé <=
- [PATCH v7 04/31] exec: Use uintptr_t in cpu_ldst.h, Richard Henderson, 2021/02/12
- [PATCH v7 08/31] bsd-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2021/02/12
- [PATCH v7 13/31] linux-user: Explicitly untag memory management syscalls, Richard Henderson, 2021/02/12
- [PATCH v7 09/31] linux-user: Do not use guest_addr_valid for h2g_valid, Richard Henderson, 2021/02/12
- [PATCH v7 07/31] linux-user: Tidy VERIFY_READ/VERIFY_WRITE, Richard Henderson, 2021/02/12
- [PATCH v7 12/31] exec: Use cpu_untagged_addr in g2h; split out g2h_untagged, Richard Henderson, 2021/02/12
- [PATCH v7 15/31] exec: Rename guest_{addr,range}_valid to *_untagged, Richard Henderson, 2021/02/12
- [PATCH v7 11/31] exec: Introduce cpu_untagged_addr, Richard Henderson, 2021/02/12
- [PATCH v7 10/31] linux-user: Fix guest_addr_valid vs reserved_va, Richard Henderson, 2021/02/12