Re: [RFC PATCH 02/15] sd: add eMMC support

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH 02/15] sd: add eMMC support

From:	Luc Michel
Subject:	Re: [RFC PATCH 02/15] sd: add eMMC support
Date:	Sat, 13 Feb 2021 14:18:31 +0100
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/11/21 9:17 AM, Sai Pavan Boddu wrote:

From: Vincent Palatin <vpalatin@chromium.org>

The parameters mimick a real 4GB eMMC, but it can be set to various
sizes.

Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
[SPB: Rebased the patch over qemu 5.1,
       Mark eMMC to support all timing modes]
Signed-off-by: Sai Pavan Boddu <sai.pavan.boddu@xilinx.com>
Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Cédric Le Goater <clg@kaod.org>

I find this commit hard to review in its current state. Maybe bysplitting it into smaller commits with a small description in the commitmessage would make things easier. Eg. one patch to set the ext_csdfields, one for the csd, and one per command you modify.


I also noted one small thing bellow.

---
  hw/sd/sd.c             | 143 +++++++++++++++++++++++++++++++++++++++++--------
  hw/sd/sdmmc-internal.c |   2 +-
  2 files changed, 122 insertions(+), 23 deletions(-)

diff --git a/hw/sd/sd.c b/hw/sd/sd.c
index 8517dbc..a75fa1c 100644
--- a/hw/sd/sd.c
+++ b/hw/sd/sd.c


[snip]

@@ -371,6 +374,51 @@ static const uint8_t sd_csd_rw_mask[16] = {
      0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xfc, 0xfe,
  };

+static void mmc_set_ext_csd(SDState *sd, uint64_t size)

+{
+    uint32_t sectcount = size >> HWBLOCK_SHIFT;
+
+    memset(sd->ext_csd, 0, 512);

memset(sd->ext_csd, 0, sizeof(sd->ext_csd));

--
Luc

+    sd->ext_csd[504] = 0x1; /* supported command sets */
+    sd->ext_csd[503] = 0x1; /* HPI features  */
+    sd->ext_csd[502] = 0x1; /* Background operations support */
+    sd->ext_csd[241] = 0xA; /* 1st initialization time after partitioning */
+    sd->ext_csd[232] = 0x1; /* Trim multiplier */
+    sd->ext_csd[231] = 0x15; /* Secure feature support */
+    sd->ext_csd[230] = 0x96; /* Secure erase support */
+    sd->ext_csd[229] = 0x96; /* Secure TRIM multiplier */
+    sd->ext_csd[228] = 0x7; /* Boot information */
+    sd->ext_csd[226] = 0x8; /* Boot partition size */
+    sd->ext_csd[225] = 0x6; /* Access size */
+    sd->ext_csd[224] = 0x4; /* HC Erase unit size */
+    sd->ext_csd[223] = 0x1; /* HC erase timeout */
+    sd->ext_csd[222] = 0x1; /* Reliable write sector count */
+    sd->ext_csd[221] = 0x4; /* HC write protect group size */
+    sd->ext_csd[220] = 0x8; /* Sleep current VCC  */
+    sd->ext_csd[219] = 0x7; /* Sleep current VCCQ */
+    sd->ext_csd[217] = 0x11; /* Sleep/Awake timeout */
+    sd->ext_csd[215] = (sectcount >> 24) & 0xff; /* Sector count */
+    sd->ext_csd[214] = (sectcount >> 16) & 0xff; /* ... */
+    sd->ext_csd[213] = (sectcount >> 8) & 0xff;  /* ... */
+    sd->ext_csd[212] = (sectcount & 0xff);       /* ... */
+    sd->ext_csd[210] = 0xa; /* Min write perf for 8bit@52Mhz */
+    sd->ext_csd[209] = 0xa; /* Min read perf for 8bit@52Mhz  */
+    sd->ext_csd[208] = 0xa; /* Min write perf for 4bit@52Mhz */
+    sd->ext_csd[207] = 0xa; /* Min read perf for 4bit@52Mhz */
+    sd->ext_csd[206] = 0xa; /* Min write perf for 4bit@26Mhz */
+    sd->ext_csd[205] = 0xa; /* Min read perf for 4bit@26Mhz */
+    sd->ext_csd[199] = 0x1; /* Partition switching timing */
+    sd->ext_csd[198] = 0x1; /* Out-of-interrupt busy timing */
+    sd->ext_csd[196] = 0xFF; /* Card type */
+    sd->ext_csd[194] = 0x2; /* CSD Structure version */
+    sd->ext_csd[192] = 0x5; /* Extended CSD revision */
+    sd->ext_csd[168] = 0x1; /* RPMB size */
+    sd->ext_csd[160] = 0x3; /* Partinioning support */
+    sd->ext_csd[159] = 0x00; /* Max enhanced area size */
+    sd->ext_csd[158] = 0x00; /* ... */
+    sd->ext_csd[157] = 0xEC; /* ... */
+}
+
  static void sd_set_csd(SDState *sd, uint64_t size)
  {
      int hwblock_shift = HWBLOCK_SHIFT;
@@ -384,7 +432,34 @@ static void sd_set_csd(SDState *sd, uint64_t size)
      }
      csize = (size >> (CMULT_SHIFT + hwblock_shift)) - 1;

- if (size <= SDSC_MAX_CAPACITY) { /* Standard Capacity SD */

+    if (sd->emmc) { /* eMMC */
+        sd->csd[0] = 0xd0;
+        sd->csd[1] = 0x0f;
+        sd->csd[2] = 0x00;
+        sd->csd[3] = 0x32;
+        sd->csd[4] = 0x0f;
+        if (size <= 0x80000000ULL) {
+            /* use 1k blocks */
+            uint32_t csize1k = (size >> (CMULT_SHIFT + 10)) - 1;
+            sd->csd[5] = 0x5a;
+            sd->csd[6] = 0x80 | ((csize1k >> 10) & 0xf);
+            sd->csd[7] = (csize1k >> 2) & 0xff;
+        } else { /* >= 2GB : size stored in ext CSD, block addressing */
+            sd->csd[5] = 0x59;
+            sd->csd[6] = 0x8f;
+            sd->csd[7] = 0xff;
+            sd->ocr |= 1 << 30;
+        }
+        sd->csd[8] = 0xff;
+        sd->csd[9] = 0xff;
+        sd->csd[10] = 0xf7;
+        sd->csd[11] = 0xfe;
+        sd->csd[12] = 0x49;
+        sd->csd[13] = 0x10;
+        sd->csd[14] = 0x00;
+        sd->csd[15] = (sd_crc7(sd->csd, 15) << 1) | 1;
+        mmc_set_ext_csd(sd, size);
+    } else if (size <= SDSC_MAX_CAPACITY) { /* Standard Capacity SD */
          sd->csd[0] = 0x00; /* CSD structure */
          sd->csd[1] = 0x26; /* Data read access-time-1 */
          sd->csd[2] = 0x00; /* Data read access-time-2 */
@@ -431,9 +506,13 @@ static void sd_set_csd(SDState *sd, uint64_t size)
      sd->csd[15] = (sd_crc7(sd->csd, 15) << 1) | 1;
  }

-static void sd_set_rca(SDState *sd)

+static void sd_set_rca(SDState *sd, uint16_t value)
  {
-    sd->rca += 0x4567;
+    if (sd->emmc) {
+        sd->rca = value;
+    } else {
+        sd->rca += 0x4567;
+    }
  }

FIELD(CSR, AKE_SEQ_ERROR, 3, 1)

@@ -979,8 +1058,8 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, 
SDRequest req)
          case sd_identification_state:
          case sd_standby_state:
              sd->state = sd_standby_state;
-            sd_set_rca(sd);
-            return sd_r6;
+            sd_set_rca(sd, req.arg >> 16);
+            return sd->emmc ? sd_r1 : sd_r6;

default:

              break;
@@ -1054,24 +1133,37 @@ static sd_rsp_type_t sd_normal_command(SDState *sd, 
SDRequest req)
          }
          break;

- case 8: /* CMD8: SEND_IF_COND */

-        if (sd->spec_version < SD_PHY_SPECv2_00_VERS) {
-            break;
-        }
-        if (sd->state != sd_idle_state) {
-            break;
-        }
-        sd->vhs = 0;
-
-        /* No response if not exactly one VHS bit is set.  */
-        if (!(req.arg >> 8) || (req.arg >> (ctz32(req.arg & ~0xff) + 1))) {
-            return sd->spi ? sd_r7 : sd_r0;
-        }
+    case 8:    /* CMD8:   SEND_IF_COND / SEND_EXT_CSD */
+        if (sd->emmc) {
+            switch (sd->state) {
+            case sd_transfer_state:
+                /* MMC : Sends the EXT_CSD register as a Block of data */
+                sd->state = sd_sendingdata_state;
+                memcpy(sd->data, sd->ext_csd, 512);
+                sd->data_start = addr;
+                sd->data_offset = 0;
+                return sd_r1;
+            default:
+                break;
+            }
+        } else {
+            if (sd->spec_version < SD_PHY_SPECv2_00_VERS) {
+                break;
+            }
+            if (sd->state != sd_idle_state) {
+                break;
+            }
+            sd->vhs = 0;

- /* Accept. */

-        sd->vhs = req.arg;
-        return sd_r7;
+            /* No response if not exactly one VHS bit is set.  */
+            if (!(req.arg >> 8) || (req.arg >> (ctz32(req.arg & ~0xff) + 1))) {
+                return sd->spi ? sd_r7 : sd_r0;
+            }

+ /* Accept. */

+            sd->vhs = req.arg;
+            return sd_r7;
+        }
      case 9:   /* CMD9:   SEND_CSD */
          switch (sd->state) {
          case sd_standby_state:
@@ -1993,7 +2085,13 @@ uint8_t sd_read_byte(SDState *sd)
          if (sd->data_offset >= 64)
              sd->state = sd_transfer_state;
          break;
+    case 8:     /* CMD8: SEND_EXT_CSD on MMC */
+        ret = sd->data[sd->data_offset++];

+ if (sd->data_offset >= 512) {

+            sd->state = sd_transfer_state;
+        }
+        break;
      case 9:   /* CMD9:   SEND_CSD */
      case 10:  /* CMD10:  SEND_CID */
          ret = sd->data[sd->data_offset ++];
@@ -2176,6 +2274,7 @@ static Property sd_properties[] = {
       * board to ensure that ssi transfers only occur when the chip select
       * is asserted.  */
      DEFINE_PROP_BOOL("spi", SDState, spi, false),
+    DEFINE_PROP_BOOL("emmc", SDState, emmc, false),
      DEFINE_PROP_END_OF_LIST()
  };

diff --git a/hw/sd/sdmmc-internal.c b/hw/sd/sdmmc-internal.c

index 2053def..8648a78 100644
--- a/hw/sd/sdmmc-internal.c
+++ b/hw/sd/sdmmc-internal.c
@@ -14,7 +14,7 @@
  const char *sd_cmd_name(uint8_t cmd)
  {
      static const char *cmd_abbrev[SDMMC_CMD_MAX] = {
-         [0]    = "GO_IDLE_STATE",
+         [0]    = "GO_IDLE_STATE",           [1]    = "SEND_OP_CMD",
           [2]    = "ALL_SEND_CID",            [3]    = "SEND_RELATIVE_ADDR",
           [4]    = "SET_DSR",                 [5]    = "IO_SEND_OP_COND",
           [6]    = "SWITCH_FUNC",             [7]    = "SELECT/DESELECT_CARD",

[Prev in Thread]

Current Thread

[Next in Thread]

[RFC PATCH 00/15] eMMC support, Sai Pavan Boddu, 2021/02/11
- [RFC PATCH 01/15] block: add eMMC block device type, Sai Pavan Boddu, 2021/02/11
  - Re: [RFC PATCH 01/15] block: add eMMC block device type, Alistair Francis, 2021/02/12
- [RFC PATCH 02/15] sd: add eMMC support, Sai Pavan Boddu, 2021/02/11
  - Re: [RFC PATCH 02/15] sd: add eMMC support, Luc Michel <=
- [RFC PATCH 04/15] sd: emmc: Update CMD1 definition for eMMC, Sai Pavan Boddu, 2021/02/11
  - Re: [RFC PATCH 04/15] sd: emmc: Update CMD1 definition for eMMC, Alistair Francis, 2021/02/12
- [RFC PATCH 09/15] sd: emmc: Add support for emmc erase, Sai Pavan Boddu, 2021/02/11
  - Re: [RFC PATCH 09/15] sd: emmc: Add support for emmc erase, Alistair Francis, 2021/02/12
    - RE: [RFC PATCH 09/15] sd: emmc: Add support for emmc erase, Sai Pavan Boddu, 2021/02/16
- [RFC PATCH 12/15] sd: emmc: Support boot area in emmc image, Sai Pavan Boddu, 2021/02/11
  - Re: [RFC PATCH 12/15] sd: emmc: Support boot area in emmc image, Alistair Francis, 2021/02/12
- [RFC PATCH 13/15] sd: emmc: Subtract bootarea size from blk, Sai Pavan Boddu, 2021/02/11
  - Re: [RFC PATCH 13/15] sd: emmc: Subtract bootarea size from blk, Alistair Francis, 2021/02/12
- [RFC PATCH 05/15] sd: emmc: support idle state in CMD2, Sai Pavan Boddu, 2021/02/11

Prev by Date: Re: Qemu mipssim patches, mips malta and virtio bugs
Next by Date: Re: About creating machines on the command line
Previous by thread: [RFC PATCH 02/15] sd: add eMMC support
Next by thread: [RFC PATCH 04/15] sd: emmc: Update CMD1 definition for eMMC
Index(es):
- Date
- Thread