[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[RFC PATCH 00/42] target/mips: Reintroduce the R5900 CPU (with more test

From: Philippe Mathieu-Daudé
Subject: [RFC PATCH 00/42] target/mips: Reintroduce the R5900 CPU (with more testing)
Date: Sun, 14 Feb 2021 18:58:30 +0100

The R5900 CPU was removed some time ago (frankly I don't remember
why). This series add it back, but to prove it works, we also add
testing at the end.

The main motivation is to have MIPS R5900 coverage, but to be able
to run real world r5900 binaries, I had to implement more opcodes.

42 patches are a lot, but 3 are already queued in linux-user-for-6.0,
and the 11 last ones are pure testing. I suppose in next versions
I'll split the testing patches, but to show the final objective I
included them in here.

I tagged it RFC because some parts because:

- We'd rather not add yet another target, but we need the
  ILP32-on-64bit ABI (o32 64-bit)

- RDHWR glibc kludge for user-mode

- Avocado patches are only here to show the final test.
  They are useful for my set of tests, but not meant to
  be merged in mainstream.

- gitlab jobs are only here to show the tests work.
  If the target is ever accepted, it would go in an already
  existing job.

I'm OK to maintain 64-bit o32 and the testing out of tree, but the
TCG opcodes are worthwhile review for mainstream.

Note: there is a sign-extension bug somewhere but I can't find it:

 $ qemu-r5900o32el busybox free
=A0total =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0used =C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0free =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0sha=
red =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0buffers
  =C2=A0Mem: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A03682012 =C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0812620 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A02869392 =C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A01367556 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0321136
  Swap: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A02095100 =C2=A0=C2=A0=C2=A0=C2=A0-149854=
4 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A03593644
 Total: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A05777112 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-=
685924 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A06463036

 $ free # host
=A0total =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0used =C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0free =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0shared =C2=A0buff/cac=
he =C2=A0=C2=A0available
 Mem: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A016264924 =C2=A0=C2=A0=C2=A0=C2=A093=
23500 =C2=A0=C2=A0=C2=A0=C2=A02822500 =C2=A0=C2=A0=C2=A0=C2=A01377288 =C2=A0=
=C2=A0=C2=A0=C2=A04118924 =C2=A0=C2=A0=C2=A0=C2=A05149548
 Swap: =C2=A0=C2=A0=C2=A0=C2=A0=C2=A018872316 =C2=A0=C2=A0=C2=A011084368 =C2=

See the used swap:

  11084368 =3D 0x00a92250
  -1498544 =3D 0xffe92250

Fredrik Noring (2):
  linux-user/mips64: Support the n32 ABI for the R5900
  tests/tcg/mips: Test user mode DMULT for the R5900

Philippe Mathieu-Daud=C3=A9 (40):
  linux-user/mips64: Restore setup_frame() for o32 ABI
  linux-user/mips64: Support o32 ABI syscalls
  target/mips/translate: Make cpu_HI/LO registers public
  target/mips: Promote 128-bit multimedia registers as global ones
  target/mips: Rename 128-bit upper halve GPR registers
  target/mips: Introduce gen_load_gpr_hi() / gen_store_gpr_hi() helpers
  target/mips/translate: Use GPR move functions in gen_HILO1_tx79()
  target/mips/tx79: Move MFHI1 / MFLO1 opcodes to decodetree
  target/mips/tx79: Move MTHI1 / MTLO1 opcodes to decodetree
  target/mips/translate: Simplify PCPYH using deposit_i64()
  target/mips/tx79: Move PCPYH opcode to decodetree
  target/mips/tx79: Move PCPYLD / PCPYUD opcodes to decodetree
  target/mips: Remove 'C790 Multimedia Instructions' dead code
  target/mips/tx79: Salvage instructions description comment
  target/mips/tx79: Introduce PAND/POR/PXOR/PNOR opcodes (parallel
  target/mips/tx79: Introduce PSUB* opcodes (Parallel Subtract)
  target/mips/tx79: Introduce PEXTUW (Parallel Extend Upper from Word)
  target/mips/tx79: Introduce PEXTU[BHW] opcodes (Parallel Extend Lower)
  target/mips/tx79: Introduce PCEQ* opcodes (Parallel Compare for Equal)
  target/mips/tx79: Introduce PCGT* (Parallel Compare for Greater Than)
  target/mips/tx79: Introduce PPACW opcode (Parallel Pack to Word)
  target/mips/tx79: Introduce PINTEH (Parallel Interleave Even Halfword)
  target/mips/tx79: Introduce PEXE[HW] opcodes (Parallel Exchange Even)
  target/mips/tx79: Introduce PROT3W opcode (Parallel Rotate 3 Words)
  target/mips/tx79: Introduce LQ opcode (Load Quadword)
  target/mips/tx79: Introduce SQ opcode (Store Quadword)
  target/mips/translate: Make gen_rdhwr() public
  target/mips/tx79: Move RDHWR usermode kludge to trans_SQ()
  target/mips: Reintroduce the R5900 CPU
  default-configs: Support o32 ABI with R5900 64-bit MIPS CPU
  docker: Add gentoo-mipsr5900el-cross image
  gitlab-ci: Pass optional EXTRA_FILES when building docker images
  gitlab-ci: Build MIPS R5900 cross-toolchain (Gentoo based)
  tests/tcg: Add MIPS R5900 to arches filter
  gitlab-ci: Add job to test the MIPS r5900o32el target
  tests/acceptance: Extract QemuBaseTest from Test
  tests/acceptance: Make pick_default_qemu_bin() more generic
  tests/acceptance: Introduce QemuUserTest base class
  tests/acceptance: Test R5900 CPU with BusyBox from Sony PS2
  gitlab-ci: Add job to run integration tests for the r5900o32el target

 docs/user/main.rst                            |   3 +
 .../targets/r5900o32el-linux-user.mak         |   7 +
 linux-user/mips64/syscall_nr.h                |   5 +-
 linux-user/mips64/target_elf.h                |   3 +
 linux-user/mips64/target_signal.h             |   4 +
 target/mips/cpu.h                             |  10 +-
 target/mips/translate.h                       |  14 +
 target/mips/tx79.decode                       |  76 ++
 target/mips/translate.c                       | 862 +----------------
 target/mips/tx79_translate.c                  | 877 ++++++++++++++++++
 target/mips/txx9_translate.c                  |  20 +
 tests/tcg/mips/mipsn32r5900/dmult.c           |  40 +
 target/mips/cpu-defs.c.inc                    |  59 ++
 .gitlab-ci.d/containers.yml                   |   8 +
 .gitlab-ci.yml                                |  22 +
 MAINTAINERS                                   |   1 +
 target/mips/meson.build                       |   5 +
 tests/acceptance/avocado_qemu/__init__.py     |  56 +-
 tests/acceptance/mips_r5900_ps2.py            |  69 ++
 tests/docker/Makefile.include                 |   3 +
 .../gentoo-mipsr5900el-cross.docker           |  35 +
 .../crossdev.conf                             |   5 +
 tests/tcg/configure.sh                        |   8 +-
 tests/tcg/mips/mipsn32r5900/Makefile          |  25 +
 24 files changed, 1375 insertions(+), 842 deletions(-)
 create mode 100644 default-configs/targets/r5900o32el-linux-user.mak
 create mode 100644 target/mips/tx79.decode
 create mode 100644 target/mips/tx79_translate.c
 create mode 100644 target/mips/txx9_translate.c
 create mode 100644 tests/tcg/mips/mipsn32r5900/dmult.c
 create mode 100644 tests/acceptance/mips_r5900_ps2.py
 create mode 100644 tests/docker/dockerfiles/gentoo-mipsr5900el-cross.docker
 create mode 100644 tests/docker/dockerfiles/gentoo-mipsr5900el-cross.docker.=
 create mode 100644 tests/tcg/mips/mipsn32r5900/Makefile


reply via email to

[Prev in Thread] Current Thread [Next in Thread]