[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/9] hw/display/tc6393xb: Inline tc6393xb_draw_graphic32() at
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 4/9] hw/display/tc6393xb: Inline tc6393xb_draw_graphic32() at its callsite |
|
Date: |
Mon, 15 Feb 2021 11:56:46 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/15/21 11:32 AM, Peter Maydell wrote:
> The function tc6393xb_draw_graphic32() is called in exactly one place,
> so just inline the function body at its callsite. This allows us to
> drop the template header entirely.
>
> The code move includes a single added space after 'for' to fix
> the coding style.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> hw/display/tc6393xb_template.h | 45 ----------------------------------
> hw/display/tc6393xb.c | 23 ++++++++++++++---
> 2 files changed, 19 insertions(+), 49 deletions(-)
> delete mode 100644 hw/display/tc6393xb_template.h
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
- [PATCH 0/9] arm: drop dead code for non-32-bit-RGB surfaces, Peter Maydell, 2021/02/15
- [PATCH 1/9] hw/arm/musicpal: Remove dead code for non-32-bit-RGB surfaces, Peter Maydell, 2021/02/15
- [PATCH 5/9] hw/display/omap_lcdc: Expand out macros in template header, Peter Maydell, 2021/02/15
- [PATCH 3/9] hw/display/tc6393xb: Expand out macros in template header, Peter Maydell, 2021/02/15
- [PATCH 4/9] hw/display/tc6393xb: Inline tc6393xb_draw_graphic32() at its callsite, Peter Maydell, 2021/02/15
- Re: [PATCH 4/9] hw/display/tc6393xb: Inline tc6393xb_draw_graphic32() at its callsite,
Philippe Mathieu-Daudé <=
- [PATCH 2/9] hw/display/tc6393xb: Remove dead code for handling non-32bpp surfaces, Peter Maydell, 2021/02/15
- [PATCH 6/9] hw/display/omap_lcdc: Drop broken bigendian ifdef, Peter Maydell, 2021/02/15
- [PATCH 7/9] hw/display/omap_lcdc: Fix coding style issues in template header, Peter Maydell, 2021/02/15
- [PATCH 8/9] hw/display/omap_lcdc: Inline template header into C file, Peter Maydell, 2021/02/15
- [PATCH 9/9] hw/display/omap_lcdc: Delete unnecessary macro, Peter Maydell, 2021/02/15
- Re: [PATCH 0/9] arm: drop dead code for non-32-bit-RGB surfaces, Richard Henderson, 2021/02/15