Re: [PATCH v2 11/12] spitz: put some Spitz-family devices into the correct category

[Philippe Mathieu-Daudé]

Hi,

On 11/30/20 9:36 AM, Gan Qixin wrote:
> Some Spitz-family devices have no category, put them into the correct 
> category.
> 
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: Peter Maydell <peter.maydell@linaro.org>
> ---
>  hw/arm/spitz.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c
> index 32bdeacfd3..0e5e8a4634 100644
> --- a/hw/arm/spitz.c
> +++ b/hw/arm/spitz.c
> @@ -1218,6 +1218,7 @@ static void corgi_ssp_class_init(ObjectClass *klass, 
> void *data)
>      k->realize = corgi_ssp_realize;
>      k->transfer = corgi_ssp_transfer;
>      dc->vmsd = &vmstate_corgi_ssp_regs;
> +    set_bit(DEVICE_CATEGORY_MISC, dc->categories);

OK.

>  }
>  
>  static const TypeInfo corgi_ssp_info = {
> @@ -1247,6 +1248,7 @@ static void spitz_lcdtg_class_init(ObjectClass *klass, 
> void *data)
>      k->realize = spitz_lcdtg_realize;
>      k->transfer = spitz_lcdtg_transfer;
>      dc->vmsd = &vmstate_spitz_lcdtg_regs;
> +    set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);

This is not a display device, but a regulator to
control the display backlight. DEVICE_CATEGORY_MISC
seems more appropriate.

>  }
>  
>  static const TypeInfo spitz_lcdtg_info = {
> 

Regards,

Phil.