Re: [PATCH 2/2] monitor/qmp: Stop processing requests when shutdown is requested

[Markus Armbruster]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 15.02.2021 um 13:09 hat Markus Armbruster geschrieben:
>> Kevin Wolf <kwolf@redhat.com> writes:
>> 
>> > monitor_qmp_dispatcher_co() used to check whether shutdown is requested
>> 
>> "used to": until when?
>
> Until right before this patch. Do you prefer present tense to describe
> the old state?

I've done it both ways.  I think present tense works better for me.
Case in point: I wasn't confident I read your commit message correctly,
so I asked.

> Also, does your Tested-by imply that you expect someone else to merge
> this series? I'm planning to send a pull request today, so if that was
> your intention, I can include it there.

I didn't mean to imply anything beyond "I ran my reproducer, and your
patches fix it."

I don't mind you including the fixes in your pull request.  I also don't
mind doing a pull request for your fixes.  Up to you!