Re: [PATCH 2/2] monitor/qmp: Stop processing requests when shutdown is requested

[Markus Armbruster]

Kevin Wolf <kwolf@redhat.com> writes:

> Am 15.02.2021 um 13:42 hat Markus Armbruster geschrieben:
>> Kevin Wolf <kwolf@redhat.com> writes:
>> 
>> > Am 15.02.2021 um 13:09 hat Markus Armbruster geschrieben:
>> >> Kevin Wolf <kwolf@redhat.com> writes:
>> >> 
>> >> > monitor_qmp_dispatcher_co() used to check whether shutdown is requested
>> >> 
>> >> "used to": until when?
>> >
>> > Until right before this patch. Do you prefer present tense to describe
>> > the old state?
>> 
>> I've done it both ways.  I think present tense works better for me.
>> Case in point: I wasn't confident I read your commit message correctly,
>> so I asked.
>
> I guess I can just add "Before this patch, ..." to clarify.

Yes, please.

>> > Also, does your Tested-by imply that you expect someone else to merge
>> > this series? I'm planning to send a pull request today, so if that was
>> > your intention, I can include it there.
>> 
>> I didn't mean to imply anything beyond "I ran my reproducer, and your
>> patches fix it."
>> 
>> I don't mind you including the fixes in your pull request.  I also
>> don't mind doing a pull request for your fixes.  Up to you!
>
> Ok, if you don't mind either way, I'll just fix up the commit message
> and include it.
>
> I just asked because it has happened before that everyone was waiting
> for someone else to merge a patch. So I made it a habit to ask when a
> maintainer replies with some kind of approval without mentioning that
> they queued the patch, because that could be a sign that they expect it
> to go through a different tree.

Not a bad habit.

Thanks!