Re: [RFC PATCH 04/42] target/mips: Promote 128-bit multimedia registers as global ones

[Richard Henderson]

On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote:
> +#if defined(TARGET_MIPS64)
> +extern TCGv_i64 cpu_gpr_hi[32];
> +#endif

Declaration needs to match...

> +/*
> + * For CPUs using 128-bit GPR registers, we put the lower halves in 
> cpu_gpr[])
> + * and the upper halves in cpu_gpr_hi[].
> + */
> +TCGv_i64 cpu_gpr_hi[32];

definition wrt ifdef.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~