[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 12/42] target/mips/tx79: Move PCPYLD / PCPYUD opcodes to
From: |
Richard Henderson |
Subject: |
Re: [RFC PATCH 12/42] target/mips/tx79: Move PCPYLD / PCPYUD opcodes to decodetree |
Date: |
Mon, 15 Feb 2021 08:28:25 -0800 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/14/21 9:58 AM, Philippe Mathieu-Daudé wrote:
> + if (a->rs == 0) {
> + tcg_gen_movi_i64(cpu_gpr_hi[a->rd], 0);
> + } else {
> + tcg_gen_mov_i64(cpu_gpr_hi[a->rd], cpu_gpr[a->rs]);
> + }
> +
> + if (a->rt == 0) {
> + tcg_gen_movi_i64(cpu_gpr[a->rd], 0);
> + } else if (a->rd != a->rt) {
> + tcg_gen_mov_i64(cpu_gpr[a->rd], cpu_gpr[a->rt]);
> + }
Use gen_load_gpr. Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
- Re: [RFC PATCH 07/42] target/mips/translate: Use GPR move functions in gen_HILO1_tx79(), (continued)
- [RFC PATCH 08/42] target/mips/tx79: Move MFHI1 / MFLO1 opcodes to decodetree, Philippe Mathieu-Daudé, 2021/02/14
- [RFC PATCH 09/42] target/mips/tx79: Move MTHI1 / MTLO1 opcodes to decodetree, Philippe Mathieu-Daudé, 2021/02/14
- [RFC PATCH 10/42] target/mips/translate: Simplify PCPYH using deposit_i64(), Philippe Mathieu-Daudé, 2021/02/14
- [RFC PATCH 11/42] target/mips/tx79: Move PCPYH opcode to decodetree, Philippe Mathieu-Daudé, 2021/02/14
- [RFC PATCH 12/42] target/mips/tx79: Move PCPYLD / PCPYUD opcodes to decodetree, Philippe Mathieu-Daudé, 2021/02/14
- Re: [RFC PATCH 12/42] target/mips/tx79: Move PCPYLD / PCPYUD opcodes to decodetree,
Richard Henderson <=
- [RFC PATCH 13/42] target/mips: Remove 'C790 Multimedia Instructions' dead code, Philippe Mathieu-Daudé, 2021/02/14
- [RFC PATCH 17/42] target/mips/tx79: Introduce PEXTUW (Parallel Extend Upper from Word), Philippe Mathieu-Daudé, 2021/02/14
- [RFC PATCH 15/42] target/mips/tx79: Introduce PAND/POR/PXOR/PNOR opcodes (parallel logic), Philippe Mathieu-Daudé, 2021/02/14
- [RFC PATCH 14/42] target/mips/tx79: Salvage instructions description comment, Philippe Mathieu-Daudé, 2021/02/14
- [RFC PATCH 16/42] target/mips/tx79: Introduce PSUB* opcodes (Parallel Subtract), Philippe Mathieu-Daudé, 2021/02/14