[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] docs/sphinx/qapidoc.py: Handle change of QAPI's builtin modu

From: John Snow
Subject: Re: [PATCH] docs/sphinx/qapidoc.py: Handle change of QAPI's builtin module name
Date: Mon, 15 Feb 2021 13:10:23 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 2/12/21 11:13 AM, Peter Maydell wrote:
In commit e2bbc4eaa7f0 we changed the QAPI modules to name the built-in
module "./builtin" rather than None, but forgot to update the Sphinx
plugin. The effect of this was that when the plugin generated a dependency
file it was including a bogus dependency on a non-existent file named
"builtin", which meant that ninja would run Sphinx and rebuild all
the documentation every time even if nothing had changed.

Update the plugin to use the new name of the builtin module.

Fixes: e2bbc4eaa7f0
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
  docs/sphinx/qapidoc.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/docs/sphinx/qapidoc.py b/docs/sphinx/qapidoc.py
index e03abcbb959..b7b86b5dffb 100644
--- a/docs/sphinx/qapidoc.py
+++ b/docs/sphinx/qapidoc.py
@@ -464,7 +464,7 @@ class QAPISchemaGenDepVisitor(QAPISchemaVisitor):
          self._qapidir = qapidir
def visit_module(self, name):
-        if name is not None:
+        if name != "./builtin":
              qapifile = self._qapidir + '/' + name

Reviewed-by: John Snow <jsnow@redhat.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]