[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/6] Acceptance Tests: use the job work directory for created

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH 3/6] Acceptance Tests: use the job work directory for created VMs
Date: Mon, 15 Feb 2021 16:04:36 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/11/21 7:01 PM, Cleber Rosa wrote:
The QEMUMachine uses a base temporary directory for all temporary
needs.  By setting it to the Avocado's workdir, it's possible to
keep the temporary files during debugging sessions much more
easily by setting the "--keep-tmp" command line option.

Signed-off-by: Cleber Rosa <crosa@redhat.com>
  tests/acceptance/avocado_qemu/__init__.py | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

The changes look good to me, so:

Reviewed-by: Wainer dos Santos Moschetta <wainersm@redhat.com>

But I got confused, the patch's subject states "use the job work directory" while the documentation of `workdir` says it is a "writable directory that exists during the entire test execution (...)". In the end is it a job or test work directory?

- Wainer

diff --git a/tests/acceptance/avocado_qemu/__init__.py 
index bf54e419da..b7ab836455 100644
--- a/tests/acceptance/avocado_qemu/__init__.py
+++ b/tests/acceptance/avocado_qemu/__init__.py
@@ -172,7 +172,8 @@ class Test(avocado.Test):
def _new_vm(self, *args):
          self._sd = tempfile.TemporaryDirectory(prefix="avo_qemu_sock_")
-        vm = QEMUMachine(self.qemu_bin, sock_dir=self._sd.name)
+        vm = QEMUMachine(self.qemu_bin, base_temp_dir=self.workdir,
+                         sock_dir=self._sd.name)
          if args:
          return vm

reply via email to

[Prev in Thread] Current Thread [Next in Thread]