[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 18/22] Acceptance Tests: set up existing ssh keys by default
From: |
Willian Rampazzo |
Subject: |
Re: [PATCH 18/22] Acceptance Tests: set up existing ssh keys by default |
Date: |
Mon, 15 Feb 2021 16:25:30 -0300 |
On Wed, Feb 3, 2021 at 2:25 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> It's questionable wether it's necessary to create one brand new pair
> for each test. It's not questionable that it takes less time and
> resources to just use the keys available at "tests/keys" that exist
> for that exact reason.
>
> If a location for the public key is not given explicitly, the
> LinuxTest will now set up the existing pair of keys as the default.
> This removes the need for a lot of boiler plate code.
>
> To avoid the ssh client from erroring on permission issues, a
> directory with restricive permissions is created for the private key.
> This should still be a lot cheaper than creating a new key.
>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/avocado_qemu/__init__.py | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, (continued)
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Alex Bennée, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Max Reitz, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Alex Bennée, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Max Reitz, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Alex Bennée, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Philippe Mathieu-Daudé, 2021/02/09
- Re: [PATCH 07/22] tests/acceptance/virtiofs_submounts.py: evaluate string not length, Cleber Rosa, 2021/02/15
[PATCH 18/22] Acceptance Tests: set up existing ssh keys by default, Cleber Rosa, 2021/02/03
[PATCH 15/22] Acceptance Tests: move useful ssh methods to base class, Cleber Rosa, 2021/02/03
Re: [PATCH 00/22] Acceptance Test: introduce base class for Linux based tests, Philippe Mathieu-Daudé, 2021/02/08