|
From: | John Snow |
Subject: | Re: [PATCH 2/6] Python: expose QEMUMachine's temporary directory |
Date: | Mon, 15 Feb 2021 17:27:46 -0500 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 |
On 2/15/21 1:50 PM, Wainer dos Santos Moschetta wrote:
In qtest.QEMUQtestMachine.__init__(), the argument named 'test_dir' still make sense, right?- Wainer
It might upset pylint/mypy to rename parameters in the initializer for a parent class. If we rename it in the base class, we should rename it in the descendants, too.
(I say "might" because I have not yet worked out under the exact conditions that mypy will give you LSP warnings for initializer methods. It definitely doesn't always seem to, but I have run afoul of it enough times that I try to avoid it as a matter of habit now.)
[Prev in Thread] | Current Thread | [Next in Thread] |