[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 2/9] virtiofs_submounts.py test: Note on vmlinuz param
From: |
Cleber Rosa |
Subject: |
[PULL 2/9] virtiofs_submounts.py test: Note on vmlinuz param |
Date: |
Mon, 15 Feb 2021 23:56:58 -0500 |
From: Max Reitz <mreitz@redhat.com>
>From the cancel message, it is not entirely clear why this parameter is
mandatory now, or that it will be optional in the future. Add such a
more detailed explanation as a comment in the test source file.
Suggested-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20210212151649.252440-1-mreitz@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Willian Rampazzo <willianr@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Cleber Rosa <crosa@redhat.com>
---
tests/acceptance/virtiofs_submounts.py | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/tests/acceptance/virtiofs_submounts.py
b/tests/acceptance/virtiofs_submounts.py
index 949ca87a837..9a69b6b17bc 100644
--- a/tests/acceptance/virtiofs_submounts.py
+++ b/tests/acceptance/virtiofs_submounts.py
@@ -228,6 +228,18 @@ def live_cleanup(self):
def setUp(self):
vmlinuz = self.params.get('vmlinuz')
if vmlinuz is None:
+ """
+ The Linux kernel supports FUSE auto-submounts only as of 5.10.
+ boot_linux.py currently provides Fedora 31, whose kernel is too
+ old, so this test cannot pass with the on-image kernel (you are
+ welcome to try, hence the option to force such a test with
+ -p vmlinuz=''). Therefore, for now the user must provide a
+ sufficiently new custom kernel, or effectively explicitly
+ request failure with -p vmlinuz=''.
+ Once an image with a sufficiently new kernel is available
+ (probably Fedora 34), we can make -p vmlinuz='' the default, so
+ that this parameter no longer needs to be specified.
+ """
self.cancel('vmlinuz parameter not set; you must point it to a '
'Linux kernel binary to test (to run this test with ' \
'the on-image kernel, set it to an empty string)')
--
2.26.2
- [PULL 0/9] Acceptance Tests and Python libs patches for 2021-02-15, Cleber Rosa, 2021/02/15
- [PULL 2/9] virtiofs_submounts.py test: Note on vmlinuz param,
Cleber Rosa <=
- [PULL 1/9] Acceptance Tests: bump Avocado version requirement to 85.0, Cleber Rosa, 2021/02/15
- [PULL 3/9] Python: close the log file kept by QEMUMachine before reading it, Cleber Rosa, 2021/02/15
- [PULL 5/9] maint: Tell git that *.py files should use python diff hunks, Cleber Rosa, 2021/02/15
- [PULL 4/9] tests/acceptance/virtio-gpu.py: preserve virtio-user-gpu log, Cleber Rosa, 2021/02/15
- [PULL 6/9] Acceptance Tests: introduce LinuxTest base class, Cleber Rosa, 2021/02/15
- [PULL 7/9] Acceptance Tests: introduce method for requiring an accelerator, Cleber Rosa, 2021/02/15
- [PULL 8/9] Acceptance Tests: fix population of public key in cloudinit image, Cleber Rosa, 2021/02/15
- [PULL 9/9] Acceptance Tests: set up existing ssh keys by default, Cleber Rosa, 2021/02/15
- Re: [PULL 0/9] Acceptance Tests and Python libs patches for 2021-02-15, Peter Maydell, 2021/02/16