[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] meson.build: expose TCG cross compiler information in sum

From: Paolo Bonzini
Subject: Re: [PATCH v2] meson.build: expose TCG cross compiler information in summary
Date: Tue, 16 Feb 2021 12:07:39 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0

On 16/02/21 11:57, Philippe Mathieu-Daudé wrote:
On Tue, Feb 16, 2021 at 11:49 AM Paolo Bonzini <pbonzini@redhat.com> wrote:

On 16/02/21 11:25, Alex Bennée wrote:
Blink and you miss the cross TCG compiler stuff so lets display it
with the rest of the compiler information.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

    - use target_dirs/fs.exists() instead of find

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Using $(wildcard) could be better than TARGET_DIRS in
tests/Makefile.include, too, something like this:

diff --git a/tests/Makefile.include b/tests/Makefile.include
index d34254fb29..7203243b08 100644
--- a/tests/Makefile.include
+++ b/tests/Makefile.include
@@ -41,7 +41,7 @@ SYSEMU_TARGET_LIST := $(subst -softmmu.mak,,$(notdir \
   SPEED = quick

   # Build up our target list from the filtered list of ninja targets
-TARGETS=$(patsubst libqemu-%.fa, %, $(filter libqemu-%.fa,
+TARGETS=$(patsubst tests/tcg/config-%.mak, %, $(wildcard

   # Per guest TCG tests
   BUILD_TCG_TARGET_RULES=$(patsubst %,build-tcg-tests-%, $(TARGETS))
@@ -49,7 +49,7 @@ CLEAN_TCG_TARGET_RULES=$(patsubst %,clean-tcg-tests-%,
   RUN_TCG_TARGET_RULES=$(patsubst %,run-tcg-tests-%, $(TARGETS))

   # Probe for the Docker Builds needed for each build
-$(foreach PROBE_TARGET,$(TARGET_DIRS),                                 \
+$(foreach PROBE_TARGET,$(TARGETS),                             \
         $(eval -include $(SRC_PATH)/tests/tcg/Makefile.prereqs))

   $(BUILD_TCG_TARGET_RULES): build-tcg-tests-%: $(if

I'll test it and send it out.

Doesn't work with your diff:

make: *** No rule to make target 'run-tcg-tests-r5900o32el-linux-user'.  Stop.

Not surprising since I didn't even run "make", it's just an idea that can be done independent from Alex's patch (and was just inspired by it).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]