[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] qga: return a more explicit error on why a command is disabl
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] qga: return a more explicit error on why a command is disabled |
|
Date: |
Tue, 16 Feb 2021 09:14:02 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/16/21 7:38 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> qmp_disable_command() now takes an optional error string to return a
> more explicit error message.
>
> Fixes:
> https://bugzilla.redhat.com/show_bug.cgi?id=1928806
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> +++ b/qapi/qmp-dispatch.c
> @@ -157,7 +157,7 @@ QDict *qmp_dispatch(const QmpCommandList *cmds, QObject
> *request,
> }
> if (!cmd->enabled) {
> error_set(&err, ERROR_CLASS_COMMAND_NOT_FOUND,
> - "The command %s has been disabled for this instance",
> + cmd->err_msg ?: "The command %s has been disabled for this
> instance",
No trailing dot (good),...
> +++ b/qga/main.c
> @@ -375,7 +375,7 @@ static void ga_disable_non_whitelisted(const QmpCommand
> *cmd, void *opaque)
> }
> if (!whitelisted) {
> g_debug("disabling command: %s", name);
> - qmp_disable_command(&ga_commands, name);
> + qmp_disable_command(&ga_commands, name, "The command was disabled
> after fsfreeze.");
...while this introduces one (not good).
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org