[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/6] tests/qapi-schema: Test cases for aliases
From: |
Kevin Wolf |
Subject: |
Re: [PATCH v2 6/6] tests/qapi-schema: Test cases for aliases |
Date: |
Tue, 16 Feb 2021 16:31:58 +0100 |
Am 16.02.2021 um 16:14 hat Markus Armbruster geschrieben:
> Kevin Wolf <kwolf@redhat.com> writes:
>
> > Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> [...]
> > diff --git a/tests/qapi-schema/alias-name-bad-type.err
> > b/tests/qapi-schema/alias-name-bad-type.err
> > new file mode 100644
> > index 0000000000..489f45ff9b
> > --- /dev/null
> > +++ b/tests/qapi-schema/alias-name-bad-type.err
> > @@ -0,0 +1,2 @@
> > +alias-name-bad-type.json: In struct 'AliasStruct0':
> > +alias-name-bad-type.json:1: alias member 'name' requires a string name
>
> Would "'aliases' member 'name'..." be more consistent?
'aliases' is a list, not a single alias definition, so technically it
would have to be "'aliases' member member 'name'...", which I feel is a
bit too confusing.
I think I have consistently used "alias" for "'aliases' member"
everywhere, though. At least, that was the intention.
Kevin
[PATCH v2 3/6] qapi: Simplify full_name_nth() in qobject-input-visitor, Kevin Wolf, 2021/02/11
[PATCH v2 5/6] qapi: Add support for aliases, Kevin Wolf, 2021/02/11
[PATCH v2 1/6] qapi: Add interfaces for alias support to Visitor, Kevin Wolf, 2021/02/11