[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 6/6] virtiofsd: Do not use a thread pool by default
From: |
Dr. David Alan Gilbert (git) |
Subject: |
[PULL 6/6] virtiofsd: Do not use a thread pool by default |
Date: |
Tue, 16 Feb 2021 18:37:34 +0000 |
From: Vivek Goyal <vgoyal@redhat.com>
Currently we created a thread pool (With 64 max threads per pool) for
each virtqueue. We hoped that this will provide us with better scalability
and performance.
But in practice, we are getting better numbers in most of the cases
when we don't create a thread pool at all and a single thread per
virtqueue receives the request and processes it.
Hence, I am proposing that we switch to no thread pool by default
(equivalent of --thread-pool-size=0). This will provide out of
box better performance to most of the users. In fact other users
have confirmed that not using a thread pool gives them better
numbers. So why not use this as default. It can be changed when
somebody can fix the issues with thread pool performance.
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Message-Id: <20210210182744.27324-2-vgoyal@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
---
tools/virtiofsd/fuse_lowlevel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/virtiofsd/fuse_lowlevel.c b/tools/virtiofsd/fuse_lowlevel.c
index f78692ef66..1aa26c6333 100644
--- a/tools/virtiofsd/fuse_lowlevel.c
+++ b/tools/virtiofsd/fuse_lowlevel.c
@@ -18,7 +18,7 @@
#include <sys/file.h>
-#define THREAD_POOL_SIZE 64
+#define THREAD_POOL_SIZE 0
#define OFFSET_MAX 0x7fffffffffffffffLL
--
2.29.2
- [PULL 0/6] virtiofs queue, Dr. David Alan Gilbert (git), 2021/02/16
- [PULL 1/6] virtiofsd: Allow to build it without the tools, Dr. David Alan Gilbert (git), 2021/02/16
- [PULL 2/6] virtiofsd: vu_dispatch locking should never fail, Dr. David Alan Gilbert (git), 2021/02/16
- [PULL 4/6] virtiofsd: Save error code early at the failure callsite, Dr. David Alan Gilbert (git), 2021/02/16
- [PULL 3/6] tools/virtiofsd: Replace the word 'whitelist', Dr. David Alan Gilbert (git), 2021/02/16
- [PULL 5/6] viriofsd: Add support for FUSE_HANDLE_KILLPRIV_V2, Dr. David Alan Gilbert (git), 2021/02/16
- [PULL 6/6] virtiofsd: Do not use a thread pool by default,
Dr. David Alan Gilbert (git) <=
- Re: [PULL 0/6] virtiofs queue, Peter Maydell, 2021/02/17