[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only use
From: |
Claudio Fontana |
Subject: |
Re: [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only user |
Date: |
Tue, 16 Feb 2021 21:44:00 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
Hello Eric,
On 2/16/21 8:34 PM, Eric Blake wrote:
> On 2/16/21 4:46 AM, Claudio Fontana wrote:
>
> In the subject, s/slit/split/
thanks, fixed.
>
>> XXX Should we assert that cpu hidden flag SVME is not set,
>> when attempting to generate VMRUN and related instructions
>> in CONFIG_USER_ONLY?
>>
>> XXX Similarily, should we check for CONFIG_USER_ONLY when
>> attempting to cpu_load_efer?
>
> If you don't fix the comment, s/Similarily/Similarly/
Thanks, will probably replace the whole comment,
I was just trying to make noise with this one to attract attention :-)
Thanks,
Claudio
>
>>
>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>> Cc: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>
>
- [RFC v19 10/15] i386: move TCG btp_helper into softmmu/, (continued)
- [RFC v19 10/15] i386: move TCG btp_helper into softmmu/, Claudio Fontana, 2021/02/16
- [RFC v19 09/15] i386: split tcg excp_helper into softmmu and user parts, Claudio Fontana, 2021/02/16
- [RFC v19 12/15] i386: separate fpu_helper into user and softmmu parts, Claudio Fontana, 2021/02/16
- [RFC v19 13/15] i386: slit svm_helper into softmmu and stub-only user, Claudio Fontana, 2021/02/16
- [RFC v19 14/15] i386: split seg_helper into user-only and softmmu parts, Claudio Fontana, 2021/02/16
- [RFC v19 15/15] i386: split off softmmu part of cpu.c, Claudio Fontana, 2021/02/16
- [RFC v19 11/15] i386: split misc helper into user and softmmu parts, Claudio Fontana, 2021/02/16
- Re: [RFC v19 00/15] i386 cleanup PART 2, no-reply, 2021/02/16