[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table I

From: Igor Mammedov
Subject: Re: [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields
Date: Tue, 16 Feb 2021 23:11:40 +0100

On Mon, 15 Feb 2021 20:26:10 +0200
Marian Postevca <posteuca@mutex.one> wrote:

> Igor Mammedov <imammedo@redhat.com> writes:
> > hmm, looks like adding instead of removing
> >  
> Do you mean that the commit message does not describe the change
> correctly, or that my refactoring is too extreme?
I've meant that diff-stat shows that patch adds more lines than it removes
so I'm not sure it removes duplication.
Maybe rephrase commit message a little.

> If it is the latter, I think I tried to simplify things, by creating
> macros to be used in multiple places where this structure is created.
> And passing the structure around instead of two parameters seemed simpler.
> > have you considered, putting this field into X86MachineState?
> > (that way you will be able to handle both PC and microvm in one place,
> > without duplication io init/property setters)
> >  
> I did not, will try this approach.
this would be pure deduplication, and simpler if you do it as separate patch
and then re-factoring to static fields on top of that.
(i.e. don't mix re-factoring and deduplication)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]