[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 15/24] python: add mypy to pipenv
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v4 15/24] python: add mypy to pipenv |
Date: |
Tue, 16 Feb 2021 23:38:46 -0500 |
On Thu, Feb 11, 2021 at 01:58:47PM -0500, John Snow wrote:
> 0.730 appears to be about the oldest version that works with the
> features we want, including nice human readable output (to make sure
> iotest 297 passes), and type-parameterized Popen generics.
>
> 0.770, however, supports adding 'strict' to the config file, so require
> at least 0.770.
>
> Now that we are checking a namespace package, we need to tell mypy to
> allow PEP420 namespaces, so modify the mypy config as part of the move.
>
> mypy can now be run from the python root by typing 'mypy qemu'.
>
$ mypy qemu
qemu/utils/accel.py: error: Source file found twice under different module
names: 'qmp' and 'qemu.qmp'
Found 1 error in 1 file (errors prevented further checking)
I guess you meant 'mypy -p qemu'.
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/Pipfile | 1 +
> python/Pipfile.lock | 37 ++++++++++++++++++++++++++++++++++++-
> python/setup.cfg | 1 +
> 3 files changed, 38 insertions(+), 1 deletion(-)
>
With that change,
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
- [PATCH v4 13/24] python: Add flake8 to pipenv, (continued)
- [PATCH v4 13/24] python: Add flake8 to pipenv, John Snow, 2021/02/11
- [PATCH v4 18/24] python/qemu: add qemu package itself to pipenv, John Snow, 2021/02/11
- [PATCH v4 23/24] python: add .gitignore, John Snow, 2021/02/11
- [PATCH v4 22/24] python: add Makefile for some common tasks, John Snow, 2021/02/11
- [PATCH v4 21/24] python: add excluded dirs to flake8 config, John Snow, 2021/02/11
- [PATCH v4 24/24] gitlab: add python linters to CI, John Snow, 2021/02/11
- [PATCH v4 15/24] python: add mypy to pipenv, John Snow, 2021/02/11
- Re: [PATCH v4 15/24] python: add mypy to pipenv,
Cleber Rosa <=
- [PATCH v4 20/24] python: add pytest and tests, John Snow, 2021/02/11
- [PATCH v4 19/24] python: add devel package requirements to setuptools, John Snow, 2021/02/11
- [PATCH v4 16/24] python: move .isort.cfg into setup.cfg, John Snow, 2021/02/11
- Re: [PATCH v4 00/24] python: create installable package, Cleber Rosa, 2021/02/11