[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH RFC v3 12/12] hw/block/nvme: add support for the format nvm c
From: |
Klaus Jensen |
Subject: |
Re: [PATCH RFC v3 12/12] hw/block/nvme: add support for the format nvm command |
Date: |
Wed, 17 Feb 2021 09:26:37 +0100 |
On Feb 16 15:16, Keith Busch wrote:
> On Mon, Feb 15, 2021 at 12:02:40AM +0100, Klaus Jensen wrote:
> > From: Minwoo Im <minwoo.im@samsung.com>
> >
> > Format NVM admin command can make a namespace or namespaces to be
> > with different LBA size and metadata size with protection information
> > types.
> >
> > This patch introduces Format NVM command with LBA format, Metadata, and
> > Protection Information for the device. The secure erase operation things
> > are yet to be added.
> >
> > The parameter checks inside of this patch has been referred from
> > Keith's old branch.
>
> Oh, and here's the format command now, so my previous comment on patch
> 11 doesn't matter.
>
> > +struct nvme_aio_format_ctx {
> > + NvmeRequest *req;
> > + NvmeNamespace *ns;
> > +
> > + /* number of outstanding write zeroes for this namespace */
> > + int *count;
>
> Shouldn't this count be the NvmeRequest's opaque value?
That is already occupied by `num_formats` which tracks formats of
individual namespaces. `count` is for outstanding write zeroes on one
particular namespace.
signature.asc
Description: PGP signature
- [PATCH RFC v3 10/12] hw/block/nvme: add non-mdts command size limit for verify, (continued)
- [PATCH RFC v3 10/12] hw/block/nvme: add non-mdts command size limit for verify, Klaus Jensen, 2021/02/14
- [PATCH RFC v3 07/12] hw/block/nvme: add metadata support, Klaus Jensen, 2021/02/14
- [PATCH RFC v3 09/12] hw/block/nvme: add verify command, Klaus Jensen, 2021/02/14
- [PATCH RFC v3 04/12] hw/block/nvme: try to deal with the iov/qsg duality, Klaus Jensen, 2021/02/14
- [PATCH RFC v3 11/12] hw/block/nvme: support multiple lba formats, Klaus Jensen, 2021/02/14
- [PATCH RFC v3 12/12] hw/block/nvme: add support for the format nvm command, Klaus Jensen, 2021/02/14
- Re: [PATCH RFC v3 00/12] hw/block/nvme: metadata and end-to-end data protection support, Keith Busch, 2021/02/16