[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 35/35] Add Dockerfile for hexagon
|
From: |
Alessandro Di Federico |
|
Subject: |
Re: [PATCH v8 35/35] Add Dockerfile for hexagon |
|
Date: |
Wed, 17 Feb 2021 18:23:34 +0100 |
On Sun, 14 Feb 2021 19:50:41 +0100
Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
> Hi Alessandro!
Hi Philippe!
> I had to add this to build your image with QEMU build system:
>
> -- >8 --
>
> diff --git a/tests/docker/Makefile.include
> b/tests/docker/Makefile.include index 93b29ad823e..ba73fb4b1f0 100644
> --- a/tests/docker/Makefile.include
> +++ b/tests/docker/Makefile.include
> @@ -146,6 +146,8 @@ docker-image-debian-riscv64-cross:
> docker-image-debian10 docker-image-debian-s390x-cross:
> docker-image-debian10 docker-image-debian-sh4-cross:
> docker-image-debian10 docker-image-debian-sparc64-cross:
> docker-image-debian10
>+docker-image-debian-hexagon-cross-build-local:
> \
>+
> EXTRA_FILES:=$(SRC_PATH)/tests/docker/dockerfiles/debian-hexagon-cross.build-toolchain.sh
>
> docker-image-travis: NOUSER=1
>
> ---
OK, I'll drop `-local` (see below).
> > +++ b/tests/docker/dockerfiles/debian-hexagon-cross.docker
> > @@ -0,0 +1 @@
> > +FROM revng/qemu:debian-hexagon-cross
>
> Once this patch gets merged, the image will be available on
> qemu/qemu:debian-hexagon-cross.
>
> I suppose for the final merge patch we want:
> - rm debian-hexagon-cross.docker
> - mv debian-hexagon-cross-build-local.docker
> debian-hexagon-cross.docker
>
> Is that correct?
The `revng/qemu:debian-hexagon-cross` image was there only to let
people quickly try out a toolchain without building it from source.
If building from source is OK with you, that works for us.
In any case, people will be able to use
`qemu/qemu:debian-hexagon-cross`, right?
> If so, can you amend that detail after the '---'
> separator of the commit description so we don't merge this patch
> as it?
I'm a bit confused, do you want me to send a patch corrected by hand
here?
I'll send a new patch tomorrow.
> Also, can you add a job to build your image in
> .gitlab-ci.d/containers.yml?
OK, is there a quick way for me to test changes I make to that file?
--
Alessandro Di Federico
rev.ng Srls, CEO
- [PATCH v8 32/35] Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc, (continued)
- [PATCH v8 32/35] Hexagon (tests/tcg/hexagon) TCG tests - atomics/load/store/misc, Taylor Simpson, 2021/02/08
- [PATCH v8 22/35] Hexagon (target/hexagon) generater phase 4 - decode tree, Taylor Simpson, 2021/02/08
- [PATCH v8 30/35] Hexagon (linux-user/hexagon) Linux user emulation, Taylor Simpson, 2021/02/08
- [PATCH v8 08/35] Hexagon (target/hexagon) GDB Stub, Taylor Simpson, 2021/02/08
- [PATCH v8 21/35] Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode tree, Taylor Simpson, 2021/02/08
- [PATCH v8 35/35] Add Dockerfile for hexagon, Taylor Simpson, 2021/02/08
- Re: [PATCH v8 35/35] Add Dockerfile for hexagon, Philippe Mathieu-Daudé, 2021/02/27
- [PATCH v8 34/35] Hexagon build infrastructure, Taylor Simpson, 2021/02/08
- Re: [PATCH v8 00/35] Hexagon patch series, no-reply, 2021/02/08
- Re: [PATCH v8 00/35] Hexagon patch series, Richard Henderson, 2021/02/14