[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/5] Obey NBD spec regarding block size bounds on reply

From: Eric Blake
Subject: Re: [PATCH 0/5] Obey NBD spec regarding block size bounds on reply
Date: Thu, 18 Feb 2021 14:40:04 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

On 2/18/21 2:33 PM, no-reply@patchew.org wrote:
> Patchew URL: 
> 20210218201528.127099-1-eblake@redhat.com/">https://patchew.org/QEMU/20210218201528.127099-1-eblake@redhat.com/
> Hi,
> This series seems to have some coding style problems. See output below for
> more information:

> 5/5 Checking commit 7be641fea748 (do not apply: Revert "nbd-client: Work 
> around server BLOCK_STATUS misalignment at EOF")
> ERROR: Missing Signed-off-by: line(s)

Intentional since patch 5 is not part of the final series. (actually,
you can apply patch 5 first to see failures, then 1-4 to see how the
failures are fixed even without the interference of client-side
workarounds).  But at the end of the day, once 1-4 are upstream, we want
to keep the client-side workarounds for communication with older qemu or
with other NBD servers that have a similar compliance problem as what
gets fixed here.

Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org

reply via email to

[Prev in Thread] Current Thread [Next in Thread]