[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gitlab-ci: Remove unused container images

From: Daniel P . Berrangé
Subject: Re: [PATCH] gitlab-ci: Remove unused container images
Date: Fri, 19 Feb 2021 12:08:31 +0000
User-agent: Mutt/2.0.5 (2021-01-21)

On Fri, Feb 19, 2021 at 01:00:21PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/19/21 12:09 PM, Thomas Huth wrote:
> > We're building a lot of containers in the gitlab-CI that we never use.
> > This takes away network bandwidth and CPU time from other jobs for no
> > use, so let's remove them for now. The individual containers could be
> > re-added later when we really need them.
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  .gitlab-ci.d/containers.yml | 92 -------------------------------------
> >  1 file changed, 92 deletions(-)
> I'm not enthusiast with this patch because I use various in this list
> from time to time for testing or cross build/disas binaries. Not having
> these containers used mainstream probably show the failure of the
> project to add good testing coverage on these targets. Most of them are
> for hobbyist with little time. Removing them will make it even harder
> to add tests. Can't we keep them disabled? Or put them in manual mode?
> Why is the CI rebuilding them, shouldn't them be cached or pulled from
> the registry?

Even using the cache still takes a few minutes of execution time.

> Maybe this show having all them in the same containers.yml file is not
> good enough? Any suggestion for splitting it, so lowly used containers
> don't get rebuild every time another often used one change the YAML
> file?

IMHO they just need to be marked as manual triggered jobs.

|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|

reply via email to

[Prev in Thread] Current Thread [Next in Thread]