Re: [PATCH] iotests: Drop deprecated 'props' from object-add

[Alberto Garcia]

On Fri 19 Feb 2021 01:04:00 PM CET, Max Reitz <mreitz@redhat.com> wrote:
> Two Python syntax nit picks below.

>>       ret = vm.qmp('object-add', qom_type='throttle-group', id='tg',
>> -                 props={'x-bps-read': 4096})
>> +                 x_bps_read = 4096)
>
> To stay consistent, I think there shouldn’t be spaces around '=' here.

Right, I didn't notice that.

>> @@ -103,10 +103,9 @@ def test_concurrent_finish(write_to_stream_node):
>>           vm.qmp_log('object-add',
>>                      qom_type='throttle-group',
>>                      id='tg',
>> -                   props={
>> -                       'x-iops-write': 1,
>> -                       'x-iops-write-max': 1
>> -                   })
>> +                   x_iops_write=1,
>> +                   x_iops_write_max=1
>> +                   )
>
> This indentation looks weird to me now.  Unfortunately, flake8 finds
> this is the only correct indentation, so I have no reason to complain.
>
> Perhaps putting it on the preceding line would be better?

I'm fine either way, I can resend the patch with Kevin's suggestions.

Berto