[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH] hw/arm/xlnx-zynqmp: Remove obsolete 'has_rpu' property |
|
Date: |
Fri, 19 Feb 2021 15:40:12 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 2/19/21 12:58 PM, Peter Maydell wrote:
> On Fri, 19 Feb 2021 at 11:51, Philippe Mathieu-Daudé <f4bug@amsat.org> wrote:
>>
>> We hint the 'has_rpu' property is no longer required since commit
>> 6908ec448b4 ("xlnx-zynqmp: Properly support the smp command line
>> option") which was released in QEMU v2.11.0.
>>
>> 3 years later we feel safe enough to remove it without using the
>> usual deprecation policy.
>
> This device is marked user_creatable = false, so the only thing
> that could be setting the property is the board code that creates
> the device. So the property is not user-facing and we can remove it
> without going through the deprecation process.
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> (maybe noting the above in the commit message).
OK I'll update, thanks!