[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH] target/riscv: fix TB_FLAGS bits overlapping bug for rvv/rvh |
|
Date: |
Fri, 19 Feb 2021 08:11:53 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/19/21 1:59 AM, frank.chang@sifive.com wrote:
> +/* Skip mem_idx bits */
> +FIELD(TB_FLAGS, VL_EQ_VLMAX, 3, 1)
Why not just add the mem_idx field to the list?
The separation between the FIELDs and TB_FLAG_*_MASK is unfortunate, and will
be a continuing source of errors.
r~