[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: meson, NEED_CPU_H, CONFIG_TCG and tests/
From: |
Claudio Fontana |
Subject: |
Re: meson, NEED_CPU_H, CONFIG_TCG and tests/ |
Date: |
Fri, 19 Feb 2021 18:24:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 2/19/21 5:04 PM, Paolo Bonzini wrote:
> On 19/02/21 14:30, Thomas Huth wrote:
>>> But how could tests see this?
>>
>> The test are generic, not target-specific code, so they can not see
>> things like NEED_CPU_H, of course.
>>
>> But CONFIG_TCG seems to be defined in config-host.h, so you should be
>> able to use that define, shouldn't you?
>
> Yes, CONFIG_TCG is defined in config_hsot just for that reason:
>
> tcg_arch = config_host['ARCH']
> if not get_option('tcg').disabled()
> ...
> accelerators += 'CONFIG_TCG'
> config_host += { 'CONFIG_TCG': 'y' }
> endif
>
> It's ugly, but I kept it that way when moving accelerator configuration
> to Meson.
>
> Paolo
>
understood, thanks a lot for this important piece of the puzzle!
Ciao,
Claudio