Re: [PATCH v4 1/4] slirp: Advance libslirp submodule to add ipv6 host-forward support

[Doug Evans]

On Fri, Feb 19, 2021 at 1:38 AM Daniel P. Berrangé <berrange@redhat.com> wrote:

On Thu, Feb 18, 2021 at 12:15:35PM -0800, Doug Evans wrote:

FWIW, normally when QEMU updates libslirp, the commit message is
set to contain the "git shortlog old..new" output

Ah. In this case I'm not sure what to do as QEMU master is using Libslirp stable-4.2 branch (at least in QEMU's libslirp.git).

Samuel, please let me know what should happen here.

I may need some hand holding to come up with The Right patch to submit.

I think you know what patches are needed here, but I don't know what I should be submitting in this 1/4 patch of the series.

 

> Signed-off-by: Doug Evans <dje@google.com>
> ---
>
> Changes from v3:
> - pick up latest libslirp patch to reject ipv6 addr-any for guest address
>   - libslirp currently only provides a stateless DHCPv6 server, which means
>     it can't know in advance what the guest's IP address is, and thus
>     cannot do the "addr-any -> guest ip address" translation that is done
>     for ipv4
>
> Changes from v2:
> - this patch is new in v3, split out from v2
>
>  slirp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/slirp b/slirp
> index 8f43a99191..26ae658a83 160000
> --- a/slirp
> +++ b/slirp
> @@ -1 +1 @@
> -Subproject commit 8f43a99191afb47ca3f3c6972f6306209f367ece
> +Subproject commit 26ae658a83eeca16780cf5615c8247cbb151c3fa
> --
> 2.30.0.617.g56c4b15f3c-goog
>

Regards,
Daniel
--
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|