Re: [PATCH v5 0/5] Add support for ipv6 host forwarding

[no-reply]

Patchew URL: 20210220001322.1311139-1-dje@google.com/">https://patchew.org/QEMU/20210220001322.1311139-1-dje@google.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20210220001322.1311139-1-dje@google.com
Subject: [PATCH v5 0/5] Add support for ipv6 host forwarding

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20210220001322.1311139-1-dje@google.com -> 
patchew/20210220001322.1311139-1-dje@google.com
Switched to a new branch 'test'
9d33831 net: Extend host forwarding to support IPv6
2b79933 net/slirp.c: Refactor address parsing
5090008 inet_parse_host_and_addr: Recognize []:port (empty ipv6 address)
5c2dcad util/qemu-sockets.c: Split host:port parsing out of inet_parse
79b77c4 slirp: Advance libslirp submodule to add ipv6 host-forward support

=== OUTPUT BEGIN ===
1/5 Checking commit 79b77c431b30 (slirp: Advance libslirp submodule to add ipv6 
host-forward support)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Doug Evans via <qemu-devel@nongnu.org>

total: 1 errors, 0 warnings, 2 lines checked

Patch 1/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/5 Checking commit 5c2dcad2990c (util/qemu-sockets.c: Split host:port parsing 
out of inet_parse)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Doug Evans via <qemu-devel@nongnu.org>

total: 1 errors, 0 warnings, 117 lines checked

Patch 2/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/5 Checking commit 509000883fbd (inet_parse_host_and_addr: Recognize []:port 
(empty ipv6 address))
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Doug Evans via <qemu-devel@nongnu.org>

total: 1 errors, 0 warnings, 20 lines checked

Patch 3/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/5 Checking commit 2b7993354518 (net/slirp.c: Refactor address parsing)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Doug Evans via <qemu-devel@nongnu.org>

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#248: 
new file mode 100644

WARNING: line over 80 characters
#334: FILE: tests/acceptance/hostfwd.py:82:
+                          "host address: error parsing port in address 
':')\r\n")

total: 1 errors, 2 warnings, 315 lines checked

Patch 4/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

5/5 Checking commit 9d3383170e32 (net: Extend host forwarding to support IPv6)
ERROR: Author email address is mangled by the mailing list
#2: 
Author: Doug Evans via <qemu-devel@nongnu.org>

WARNING: line over 80 characters
#225: FILE: tests/acceptance/hostfwd.py:101:
+        self.assertEquals(self.hmc('hostfwd_add vnet 
tcp:[::1]:65022-[fe80::1]:22'),

WARNING: line over 80 characters
#228: FILE: tests/acceptance/hostfwd.py:104:
+                          'host forwarding rule for tcp:[::1]:65022 
removed\r\n')

WARNING: line over 80 characters
#236: FILE: tests/acceptance/hostfwd.py:112:
+                          'host forwarding rule for udp:[::1]:65042 
removed\r\n')

WARNING: line over 80 characters
#254: FILE: tests/acceptance/hostfwd.py:130:
+                          'host forwarding rule for udp:[::1]:65042 
removed\r\n')

WARNING: line over 80 characters
#256: FILE: tests/acceptance/hostfwd.py:132:
+                          'host forwarding rule for udp:[::1]:65042 not 
found\r\n')

WARNING: line over 80 characters
#266: FILE: tests/acceptance/hostfwd.py:142:
+                          "(For host address: error parsing IPv6 address 
'[::1')\r\n")

WARNING: line over 80 characters
#276: FILE: tests/acceptance/hostfwd.py:152:
+                          "(For host address: error parsing IPv6 address 
'[::1]')\r\n")

WARNING: line over 80 characters
#279: FILE: tests/acceptance/hostfwd.py:155:
+                          "(For guest address: error parsing IPv6 address 
'[foo]')\r\n")

WARNING: line over 80 characters
#285: FILE: tests/acceptance/hostfwd.py:161:
+                          "':[::1]:66-[fe80::1]:-1' (For guest address: Bad 
port)\r\n")

WARNING: line over 80 characters
#288: FILE: tests/acceptance/hostfwd.py:164:
+                          "':[::1]:66-[fe80::1]:66666' (For guest address: Bad 
port)\r\n")

WARNING: line over 80 characters
#291: FILE: tests/acceptance/hostfwd.py:167:
+                          "':[::1]:66-[fe80::1]:0' (For guest address: Bad 
port)\r\n")

total: 1 errors, 11 warnings, 260 lines checked

Patch 5/5 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20210220001322.1311139-1-dje@google.com/testing.checkpatch/?type=message">http://patchew.org/logs/20210220001322.1311139-1-dje@google.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com