Re: [RFC PATCH 3/5] tests: add a sdhci reproducer

[Alexander Bulekov]

On 210219 2306, Philippe Mathieu-Daudé wrote:
> On 2/18/21 10:12 PM, Alexander Bulekov wrote:
> > This patch serves as an example of a file generated with the
> > ./scripts/oss-fuzz/output_reproducer.py script:
> > The source file in this patch was generated like this:
> > 
> > $ wget https://paste.debian.net/plain/118513 -O /tmp/trace
> > $ export QEMU_ARGS="-nographic -machine accel=qtest -m 512M \
> > -nodefaults -device sdhci-pci,sd-spec-version=3 -drive \
> > if=sd,index=0,file=null-co://,format=raw,id=mydrive \
> > -device sd-card,drive=mydrive -qtest stdio"
> > $ export QEMU_PATH=./qemu-system-i386
> > $ ./scripts/oss-fuzz/output_reproducer.py \
> > -owner "Alexander Bulekov <alxndr@bu.edu>" /tmp/trace | \
> > clang-format -style="{BasedOnStyle: llvm, IndentWidth: 4, \
> > ColumnLimit: 90, BreakBeforeBraces: Linux}" > ../tests/qtest/fuzz-sdhci.c
> > 
> > Signed-off-by: Alexander Bulekov <alxndr@bu.edu>
> > ---
> >  tests/qtest/fuzz-sdhci.c | 90 ++++++++++++++++++++++++++++++++++++++++
> >  tests/qtest/meson.build  |  2 +
> >  2 files changed, 92 insertions(+)
> >  create mode 100644 tests/qtest/fuzz-sdhci.c
> ...
> 
> > diff --git a/tests/qtest/meson.build b/tests/qtest/meson.build
> > index c83bc211b6..97caf84443 100644
> > --- a/tests/qtest/meson.build
> > +++ b/tests/qtest/meson.build
> > @@ -56,6 +56,8 @@ qtests_i386 = \
> >     'rtc-test',
> >     'i440fx-test',
> >     'fuzz-test',
> > +   'fuzz-sdhci',
> > +   'sdhci-test',
> 
> This line ^ belongs to the next patch.

I think the line doesn't belong at all. The next patch justs adds to
fuzz-sdhci.c

> 
> >     'fw_cfg-test',
> >     'device-plug-test',
> >     'drive_del-test',
> >