[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 09/13] vt82c686: Fix superio_cfg_{read,write}() functions

From: BALATON Zoltan
Subject: Re: [PATCH v2 09/13] vt82c686: Fix superio_cfg_{read,write}() functions
Date: Sat, 20 Feb 2021 23:00:26 +0100 (CET)

On Sat, 20 Feb 2021, Philippe Mathieu-Daudé wrote:
On 1/9/21 9:16 PM, BALATON Zoltan wrote:
These functions are memory region callbacks so we have to check
against relative address not the mapped address. Also reduce
indentation by returning early and log unimplemented accesses.
Additionally we remove separate index value from SuperIOConfig and
store the index at reg 0 which is reserved and returns 0 on read. This
simplifies object state.

Again... Why are you putting so many changes in the same patch?

I thought these changes were simple enough to include in one patch so I don't get a series with 25 one line patches when I already have 13 patches. Also I've split these up after having it working and it was hard to separate changes after the fact even if I went through doing it again from scratch to create the separate patches.

I split it in 5 distinct patches trivial to review. I probably
shouldn't spend that amount of maintainer time with your series,
but this time I did it, my bad.

You don't have to do that, you can just tell me in review how you want these split up and then I can change it accordingly. Thanks a lot for doing it though, I can't see how this patch could be split up more than intno 2-3 patches so doing it was probably faster than explaining it in this case.


Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
 hw/isa/vt82c686.c | 63 ++++++++++++++++++++++++++---------------------
 1 file changed, 35 insertions(+), 28 deletions(-)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]