[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] linux-user: fix O_NONBLOCK usage for hppa target

From: Helge Deller
Subject: Re: [PATCH v2] linux-user: fix O_NONBLOCK usage for hppa target
Date: Mon, 22 Feb 2021 02:02:56 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0

Dear qemu-stable,

can you please consider adding this patch to the qemu-stable branch.
Upstream commit 2bdc74f3d7c4cacb65dbde910471c62992640275


On 2/13/21 5:25 PM, Laurent Vivier wrote:
Le 01/02/2021 à 23:05, Helge Deller a écrit :
Historically the parisc linux port tried to be compatible with HP-UX
userspace and as such defined the O_NONBLOCK constant to 0200004 to
emulate separate NDELAY & NONBLOCK values.

Since parisc was the only Linux platform which had two bits set, this
produced various userspace issues. Finally it was decided to drop the
(never completed) HP-UX compatibilty, which is why O_NONBLOCK was
changed upstream to only have one bit set in future with this commit:

This patch simply adjusts the value for qemu-user too.

Signed-off-by: Helge Deller <deller@gmx.de>


diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h
index bd966a59b8..08e3a4fcb0 100644
--- a/linux-user/hppa/target_fcntl.h
+++ b/linux-user/hppa/target_fcntl.h
@@ -8,7 +8,7 @@

-#define TARGET_O_NONBLOCK    000200004 /* HPUX has separate NDELAY & NONBLOCK 
+#define TARGET_O_NONBLOCK    000200000
  #define TARGET_O_APPEND      000000010
  #define TARGET_O_CREAT       000000400 /* not fcntl */
  #define TARGET_O_EXCL        000002000 /* not fcntl */

Applied to my linux-user-for-6.0 branch.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]