[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC v1 28/38] target/arm: make arm_pmu_timer_cb TCG-only, starting
|
From: |
Richard Henderson |
|
Subject: |
Re: [RFC v1 28/38] target/arm: make arm_pmu_timer_cb TCG-only, starting tcg-stub |
|
Date: |
Sun, 21 Feb 2021 22:09:16 -0800 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 |
On 2/21/21 1:24 AM, Claudio Fontana wrote:
> @@ -634,10 +635,11 @@ static int cpu_pre_save(void *opaque)
> {
> ARMCPU *cpu = opaque;
>
> - if (!kvm_enabled()) {
> +#ifdef CONFIG_TCG
> + if (tcg_enabled()) {
> pmu_op_start(&cpu->env);
> }
> -
> +#endif /* CONFIG_TCG */
Why the ifdef? Seems like a lack of stub.
I agree that !kvm rather than tcg is a bug.
r~
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [RFC v1 28/38] target/arm: make arm_pmu_timer_cb TCG-only, starting tcg-stub,
Richard Henderson <=