[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG

From: Claudio Fontana
Subject: Re: [RFC v1 05/38] target/arm: wrap arm_cpu_exec_interrupt in CONFIG_TCG
Date: Mon, 22 Feb 2021 09:31:12 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0

On 2/22/21 7:21 AM, Richard Henderson wrote:
> On 2/21/21 1:24 AM, Claudio Fontana wrote:
>> +#ifdef CONFIG_TCG
>>  bool arm_cpu_exec_interrupt(CPUState *cs, int interrupt_request)
>>  {
>>      CPUClass *cc = CPU_GET_CLASS(cs);
>> @@ -607,6 +608,7 @@ bool arm_cpu_exec_interrupt(CPUState *cs, int 
>> interrupt_request)
>>      cc->tcg_ops->do_interrupt(cs);
>>      return true;
>>  }
>> +#endif /* CONFIG_TCG */
> I presume this function gets moved later?  What does this aid in the interim?
> r~

Hi Richard,

actually this is a fix for an error I introduced when adding TCGOps:

arm_cpu_exec_interrupt should be wrapped in the ifdef, as it uses tcg_ops, 
which is TCG-only.
Maybe I should extract this and make it a standalone fix.

Currently, there is no real issue because the non-TCG build is not working for 
ARM anyway,
and that's why the issue went undetected.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]